Add metrics and statistics about aggressive locking#687
Merged
MyonKeminta merged 7 commits intotikv:masterfrom Feb 7, 2023
Merged
Add metrics and statistics about aggressive locking#687MyonKeminta merged 7 commits intotikv:masterfrom
MyonKeminta merged 7 commits intotikv:masterfrom
Conversation
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
…ressive-locking-metrics
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
cfzjywxk
reviewed
Feb 3, 2023
sticnarf
reviewed
Feb 3, 2023
Collaborator
sticnarf
left a comment
There was a problem hiding this comment.
Only a small optional suggestion.
12 tasks
ekexium
reviewed
Feb 6, 2023
| PrewriteAssertionUsageCounterNotExist prometheus.Counter | ||
| PrewriteAssertionUsageCounterUnknown prometheus.Counter | ||
|
|
||
| AggressiveLockedKeysNew prometheus.Counter |
Contributor
There was a problem hiding this comment.
Shall we add brief comments explaining them? For example "derived" is vague if not diving into code.
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
ekexium
approved these changes
Feb 7, 2023
cfzjywxk
approved these changes
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: tikv/tikv#13298