support choosing non-pending tiflash peer when buildBatchCopTask#144
Merged
gengliqi merged 8 commits intotikv:masterfrom May 31, 2023
Merged
support choosing non-pending tiflash peer when buildBatchCopTask#144gengliqi merged 8 commits intotikv:masterfrom
gengliqi merged 8 commits intotikv:masterfrom
Conversation
guo-shaoge
commented
May 28, 2023
Signed-off-by: guo-shaoge <shaoge1994@163.com>
623154a to
b48b0a7
Compare
…pending_peer Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
gengliqi
approved these changes
May 31, 2023
Member
|
/merge |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: pingcap/tiflash#7301
Before: Task can dispatch to store whose region is still pending.
After: Try not to dispatch task to pending store.
What's changed:
getRegionByKey()andgetRegionByID(), return whole response instead of only region info.