Skip to content

Fix wrong usage about Poco::URI to support ipv6#101

Merged
gengliqi merged 1 commit intotikv:masterfrom
solotzg:patch-1
Jul 1, 2022
Merged

Fix wrong usage about Poco::URI to support ipv6#101
gengliqi merged 1 commit intotikv:masterfrom
solotzg:patch-1

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented Jul 1, 2022

Ref pingcap/tiflash#5247

Host of ipv6 addr http://[::1]:2379 is ::1. To visit ipv6 host, it's necessary to encode the IPv6 IP number in square brackets according to RFC 3986. We need to use URI::getAuthority.

Signed-off-by: root <root@localhost.localdomain>
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengliqi gengliqi merged commit 034d1e7 into tikv:master Jul 1, 2022
@solotzg solotzg deleted the patch-1 branch July 1, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants