Merged
Conversation
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
676250c to
98e0eb9
Compare
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
98e0eb9 to
32d724c
Compare
slakkala
reviewed
Nov 27, 2025
slakkala
left a comment
There was a problem hiding this comment.
Bunch of comments, will continue later.
slakkala
reviewed
Nov 27, 2025
slakkala
reviewed
Nov 28, 2025
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
inzanity
reviewed
Dec 1, 2025
inzanity
left a comment
There was a problem hiding this comment.
Added another bunch of comments, but I believe the spawn_oneshot_command() usage is the only one that really needs fixing.
a1d985b to
e72c941
Compare
4b91e1d to
f852d96
Compare
slakkala
reviewed
Dec 3, 2025
f852d96 to
0c85ade
Compare
slakkala
approved these changes
Dec 4, 2025
slakkala
left a comment
There was a problem hiding this comment.
I don't think there's anything blocking anymore, some further cleanups suggested.
0c85ade to
5a95637
Compare
19 tasks
vunnyso
approved these changes
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements controlled routing scripts for WireGuard configurations, replacing user-provided PreUp/PostUp/PreDown/PostDown hooks with pre-validated scripts to enhance security. It adds embedded logos, improves configuration validation, implements non-blocking I/O for better UI responsiveness, and introduces interface binding support for routing scripts.
Key Changes:
- Replaced arbitrary command execution in WireGuard hooks with validated routing scripts
- Added configuration validation and error aggregation during initialization
- Implemented async operations for file I/O and command execution to prevent UI blocking
Reviewed changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updated Rust edition and added dependencies (anyhow, pnet_datalink) |
| src/config.rs | Added routing script parsing/validation, binding interface support, comprehensive tests |
| src/main.rs | Implemented async initialization, routing script/interface loading, embedded logos |
| src/tunnel.rs | Refactored to TunnelData model, added validation, async toggle execution |
| src/overview.rs | Added routing script/binding interface UI, field change tracking |
| src/utils.rs | Added export path validation, improved error handling, Option update helper |
| src/generator.rs | Removed hardcoded iptables rules, made operations async |
| src/cli.rs | Split config directory into configs and scripts subdirectories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5a95637 to
b5fc0e2
Compare
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
b5fc0e2 to
527b21c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreUp,PreDown,PostUp,PostDownhooks by the user with controlled routing scripts, improving security by preventing arbitrary command execution.