overlay hunt: remove unused libfm overlay#1845
Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom Mar 23, 2026
Merged
Conversation
libfm is the core library of PCManFM file manager, but Ghaf switched to COSMIC desktop which uses cosmic-files (no libfm dependency). Verified with `nix why-depends`: cosmic-files does not depend on libfm, and there are zero references to pcmanfm or libfm in the Ghaf codebase. This overlay was needlessly patching a library in the global pkgs set. As a library, any package that transitively depends on libfm would get a new derivation hash and rebuild from source instead of using the binary cache. Signed-off-by: vadik likholetov <vadikas@gmail.com>
e4e582a to
433378d
Compare
brianmcgillion
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cosmic-fileswhich has no libfm dependencynix why-depends nixpkgs#cosmic-files nixpkgs#libfm→ "does not depend on"pcmanfmorlibfmanywhere in the Ghaf codebaseTest plan
nix build .#lenovo-x1-carbon-gen11-debugsucceeds (libfm not in closure)