Skip to content

fix(chrome-extensions): fix bot check failure during extension build#1840

Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom
kajusnau:chrome-ext-fix
Mar 25, 2026
Merged

fix(chrome-extensions): fix bot check failure during extension build#1840
brianmcgillion merged 2 commits intotiiuae:mainfrom
kajusnau:chrome-ext-fix

Conversation

@kajusnau
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau commented Mar 20, 2026 •
edited
Loading

Description of Changes

  • Extension CRXs will now be fetched directly from Google servers
  • crx4chrome is still used to determine the address of the pinned version
    The approach is quite hacky, but it seems to work consistently
    If this stops working due to bot checks in the future, we will have to resort disabling pinned version extensions

Other

  • Updated Session Buddy extension 4.1.0 -> 4.1.1

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Verify Building session-buddy fails #1730 is fixed
  2. (Optional) verify session-buddy extension still works in trusted browser

@kajusnau kajusnau requested a review from henrirosten March 20, 2026 09:53
@kajusnau kajusnau self-assigned this Mar 20, 2026
@kajusnau kajusnau marked this pull request as draft March 20, 2026 10:11
@kajusnau kajusnau marked this pull request as ready for review March 20, 2026 10:24
henrirosten
henrirosten reviewed Mar 20, 2026
View reviewed changes
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Mar 20, 2026

Tested on Lenovo-X1 (new image)

  • Session Buddy is installed and works
  • Open page in normal browser extension has disappeared from the Trusted Browser :(

@milva-unikie milva-unikie added the bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR label Mar 20, 2026
@kajusnau
Copy link
Copy Markdown
Collaborator Author

kajusnau commented Mar 23, 2026

Tested on Lenovo-X1 (new image)

  • Open page in normal browser extension has disappeared from the Trusted Browser :(

Can't reproduce with latest - both extensions are available and both work 🤔

@kajusnau kajusnau requested a review from henrirosten March 23, 2026 12:02
henrirosten
henrirosten reviewed Mar 23, 2026
View reviewed changes
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Mar 24, 2026

Tested on Lenovo-X1 (new image)

  • Open page in normal browser extension has disappeared from the Trusted Browser :(

Can't reproduce with latest - both extensions are available and both work 🤔

This was my bad. I just learnt that Open page in normal browser extension is only visible in the Trusted Browser after the laptop has been connected to internet. Once I connected the extension reappeared. Same behavior in mainline.

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76 and removed bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR labels Mar 24, 2026
kajusnau added 2 commits March 24, 2026 12:47
@kajusnau
fix(chrome-extensions): fix bot check failure during extension build
2f9dda0 
Extension CRXs will now be fetched directly from Google servers,
crx4chrome is still used to determine the address of the pinned version
If this stops working due to bot checks in the future, we will have to
resort disabling pinned version extensions

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@kajusnau
session-buddy: update 4.1.0 -> 4.1.1
e067acf 
Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@brianmcgillion brianmcgillion merged commit 5673173 into tiiuae:main Mar 25, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@henrirosten henrirosten henrirosten approved these changes

Assignees

@kajusnau kajusnau

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Building session-buddy fails

4 participants

@kajusnau @milva-unikie @brianmcgillion @henrirosten