Skip to content

devshell: flash script and rebuild helper improvements#1836

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:devshell-changes
Mar 19, 2026
Merged

devshell: flash script and rebuild helper improvements#1836
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:devshell-changes

Conversation

@kajusnau
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau commented Mar 18, 2026 •
edited
Loading

Description of Changes

  • ghaf-flash: Added non-interactive mode for use in CI/CD pipelines
    • Example usage:
    $ sudo ghaf-flash -d /dev/sdb -i result/disk1.raw.zst -f -n -p 10
Estimating uncompressed size...

================ FLASH SUMMARY ================
  Image:  result/disk1.raw.zst
   Size:  70G
 Target:  /dev/sdb
   Size:  476.9G
===============================================

Wiping filesystem...
Flashing...
6207569920 bytes (6.2 GB, 5.8 GiB) copied, 10.0076 s, 620 MB/s
11811160064 bytes (12 GB, 11 GiB) copied, 20.024 s, 590 MB/s
18891145216 bytes (19 GB, 18 GiB) copied, 30.0311 s, 629 MB/s
...
  • ghaf-rebuild: added insecure mode flag to reduce ssh key prompts

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other: N/A

Test Steps To Verify:

N/A

@kajusnau kajusnau requested a review from henrirosten March 18, 2026 12:38
@kajusnau kajusnau self-assigned this Mar 18, 2026
@kajusnau kajusnau mentioned this pull request Mar 18, 2026
Merged
henrirosten
henrirosten reviewed Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@henrirosten henrirosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d propose to make the non-TTY behavior automatic.
That is, keep -n as a manual override, but also set plain/non-interactive mode automatically when stderr is not a TTY. That makes CI print usable logs without changing current callers (I believe this is used outside Jenkins too, e.g. https://github.com/tiiuae/ghaf/blob/main/.github/skills/ghaf-hw-test/ghaf-hw-test)

@kajusnau
devshell: flash script and rebuild helper improvements
2d864a3 
ghaf-flash: Added non-interactive mode for use in CI/CD pipelines
ghaf-rebuild: added insecure mode flag to reduce ssh key prompts

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@brianmcgillion brianmcgillion merged commit a7eccec into tiiuae:main Mar 19, 2026
32 checks passed
@kajusnau kajusnau deleted the devshell-changes branch March 19, 2026 10:58
@henrirosten henrirosten mentioned this pull request Mar 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@henrirosten henrirosten henrirosten approved these changes

Assignees

@kajusnau kajusnau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kajusnau @brianmcgillion @henrirosten