Skip to content

fix(suspend): resolve suspend failures and correct lid switch handling#1818

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-FixSuspend
Mar 15, 2026
Merged

fix(suspend): resolve suspend failures and correct lid switch handling#1818
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-FixSuspend

Conversation

@vunnyso
Copy link
Copy Markdown
Collaborator

@vunnyso vunnyso commented Mar 12, 2026

Description of Changes

Fix multiple issues that caused suspend failures on the host and audio VM.

Resolved the following errors:

  • ghaf-host: host-suspend-actions reported that the givc-net service was not registered during suspend.

  • audio-vm: pci-binder failed due to a missing variable, which caused systemd-suspend.service to exit with status 1.

Additionally, correct lid switch handling when the system is running on external power so that the configured lid action is applied instead of being ignored.

Fixed https://jira.tii.ae/browse/SSRCSP-7444 partially. Audio now stops during suspend, but it resumes a few seconds after the lid is opened because suspending appvms is not currently supported.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Details in PR description.

Fix multiple issues that caused suspend failures on the host and
audio VM.

Resolved the following errors:

- ghaf-host:
  host-suspend-actions reported that the givc-net service was not
  registered during suspend.

- audio-vm:
  pci-binder failed due to a missing variable, which caused
  systemd-suspend.service to exit with status 1.

Additionally, correct lid switch handling when the system is running
on external power so that the configured lid action is applied
instead of being ignored.

Signed-off-by: Vunny Sodhi <vunny.sodhi@unikie.com>
@vunnyso vunnyso requested review from brianmcgillion, kajusnau and mbssrc and removed request for mbssrc March 12, 2026 09:55
@brianmcgillion brianmcgillion merged commit 96bd506 into tiiuae:main Mar 15, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants