Skip to content

fix(wireguard-gui): populate vmconfig enabledVmNames across host/vm e…#1804

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
enesoztrk:fix/wireguard-gui-module
Mar 6, 2026
Merged

fix(wireguard-gui): populate vmconfig enabledVmNames across host/vm e…#1804
brianmcgillion merged 1 commit intotiiuae:mainfrom
enesoztrk:fix/wireguard-gui-module

Conversation

@enesoztrk
Copy link
Copy Markdown
Contributor

@enesoztrk enesoztrk commented Mar 5, 2026 •
edited
Loading

Description of Changes

Fixes WireGuard GUI VM name propagation so enabledVmNames no longer becomes empty in VM eval contexts. Wireguard GUI button will be visible on ghaf control panel again.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

https://jira.tii.ae/browse/SSRCSP-8138

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Open ghaf control panel
  2. Click "Wireguard GUI" button.

@enesoztrk
fix(wireguard-gui): populate vmconfig enabledVmNames across host/vm e…
0687906 
…val contexts

Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
@enesoztrk enesoztrk requested a review from brianmcgillion March 5, 2026 15:21
@enesoztrk enesoztrk added the Needs Testing CI Team to pre-verify label Mar 5, 2026
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Mar 6, 2026

Tested on Darter Pro

  • Wireguard can be launched from the Control Panel again
  • Wireguard connection works

@milva-unikie milva-unikie added Tested on System76 and removed Needs Testing CI Team to pre-verify labels Mar 6, 2026
@enesoztrk enesoztrk requested review from clayhill66 and vunnyso March 6, 2026 07:03
@brianmcgillion brianmcgillion merged commit b9cd29c into tiiuae:main Mar 6, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@vunnyso vunnyso vunnyso approved these changes

@clayhill66 clayhill66 Awaiting requested review from clayhill66

Assignees

No one assigned

Labels

Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@enesoztrk @milva-unikie @brianmcgillion @vunnyso