fix(faillock): update maxTries logic following upstream cosmic-greeter fix#1803
Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom Mar 6, 2026
Merged
Conversation
- Fix: https://jira.tii.ae/browse/SSRCSP-8128 - Now login screen behaviour is as per expectation. - maxTries incremented to 5 - Issue was with the old cosmic-greeter(1.0.0-alpha.7), so we had the description of the config option. Now they have fixed it in 1.0.3(currently in Ghaf). Description: The discrepancy in login limits—where the older implementation allowed 10 attempts despite a deny=2 policy—was caused by UI synchronization bugs rather than the PAM configuration itself. The previous code frequently sent empty strings (which do not increment the failure counter) due to poorly managed input states, permitted race conditions by letting users submit multiple times while PAM was still processing in the background, and swallowed subsequent login attempts by overwriting input prompts with error messages. The updated code resolves this by strictly binding the text input, locking the UI during background processing to guarantee a perfect 1-to-1 mapping of keystrokes to PAM attempts, and properly isolating error states to ensure the 2-try limit is strictly enforced. Signed-off-by: Ganga Ram <Ganga.Ram@tii.ae>
kajusnau
approved these changes
Mar 5, 2026
vunnyso
approved these changes
Mar 5, 2026
|
Tested on Darter Pro
|
brianmcgillion
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The discrepancy in login limits—where the older implementation allowed 10 attempts despite a deny=2 policy—was caused by UI synchronization bugs rather than the PAM configuration itself. The previous code frequently sent empty strings (which do not increment the failure counter) due to poorly managed input states, permitted race conditions by letting users submit multiple times while PAM was still processing in the background, and swallowed subsequent login attempts by overwriting input prompts with error messages. The updated code resolves this by strictly binding the text input, locking the UI during background processing to guarantee a perfect 1-to-1 mapping of keystrokes to PAM attempts, and properly isolating error states to ensure the 2-try limit is strictly enforced.
cosmic-greeter(1.0.0-alpha.7), so we had the description of the config option. Now they have fixed it in 1.0.3(currently in Ghaf).Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: