Skip to content

Enable logging for release profile#1802

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-fixLog
Mar 6, 2026
Merged

Enable logging for release profile#1802
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-fixLog

Conversation

@vunnyso
Copy link
Copy Markdown
Collaborator

@vunnyso vunnyso commented Mar 5, 2026 •
edited
Loading

Description of Changes

Use the default Loki endpoint for release profile logging.

Fixes: https://jira.tii.ae/browse/SSRCSP-8135

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Please verify it fixes the issue mentioned in PR description.

@vunnyso
Enable logging for release profile
49fc2de 
Use the default Loki endpoint for release profile logging.

Signed-off-by: Vunny Sodhi <vunny.sodhi@unikie.com>
@vunnyso vunnyso requested a review from brianmcgillion March 5, 2026 11:31
@vunnyso vunnyso requested a review from everton-dematos March 5, 2026 11:31
kajusnau
kajusnau approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we could/should lessen the strain on logging server if we disabled logging for debug builds

@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Mar 5, 2026

Wondering if we could/should lessen the strain on logging server if we disabled logging for debug builds

Let's not do that, the centralized logs are very helpful

@vunnyso
Copy link
Copy Markdown
Collaborator Author

vunnyso commented Mar 5, 2026

Wondering if we could/should lessen the strain on logging server if we disabled logging for debug builds

In the future, it would probably be good feature to allow logging to the server from the target system to be controlled based on user preferences.

@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Mar 5, 2026

Tested on Darter Pro

  • Logging works again with the release image, thanks @vunnyso !

@brianmcgillion brianmcgillion merged commit 7890307 into tiiuae:main Mar 6, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@kajusnau kajusnau kajusnau approved these changes

@everton-dematos everton-dematos Awaiting requested review from everton-dematos

Assignees

No one assigned

Labels

Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vunnyso @milva-unikie @brianmcgillion @kajusnau