Skip to content

qemu: fix patch to properly handle lid events#1785

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:fix-lid-switch
Feb 26, 2026
Merged

qemu: fix patch to properly handle lid events#1785
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:fix-lid-switch

Conversation

@kajusnau
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau commented Feb 25, 2026

Description of Changes

Changed QEMU lid event patch ACPI_BUTTON_CHANGE_STATUS event bits back to the correct 2048 value.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Partially reverted patch rebase done in #1721

Fixes https://jira.tii.ae/browse/SSRCSP-7968

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Verify laptops suspend when on battery power when the lid is closed

@kajusnau
qemu: fix patch to properly handle lid events
450c7e7 
Changed ACPI_BUTTON_CHANGE_STATUS event bits back to
the correct 2048 value

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@kajusnau kajusnau self-assigned this Feb 25, 2026
@kajusnau kajusnau added the Needs Testing CI Team to pre-verify label Feb 25, 2026
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Feb 26, 2026

Tested on Darter Pro and Lenovo X1

  • Laptops suspend when the lid is closed
  • They also wake up after the lid is opened again :)

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76 and removed Needs Testing CI Team to pre-verify labels Feb 26, 2026
@brianmcgillion brianmcgillion merged commit 1bc337d into tiiuae:main Feb 26, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@vunnyso vunnyso vunnyso approved these changes

Assignees

@kajusnau kajusnau

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kajusnau @milva-unikie @brianmcgillion @vunnyso