Skip to content

appvm: label virtual apps explicitly#1784

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:apps-cat-prefix
Mar 11, 2026
Merged

appvm: label virtual apps explicitly#1784
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:apps-cat-prefix

Conversation

@kajusnau
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau commented Feb 25, 2026 •
edited
Loading

Description of Changes

Add explicit labels for virtual apps' desktop entry names.

Apps like Google Chrome, Slack, Outlook, etc. will now have their respective VM label attached in one of several different ways. Please build it, run it, and check the app library to see the new labels.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. ...

@kajusnau kajusnau self-assigned this Feb 25, 2026
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Feb 25, 2026

My comments

  • I like the format [flatpak] App Store best. Not having the -vm there looks a bit weird at first, but I think that is just a matter of getting used to it. Dropping it saves some space.
  • The issue with [] is that they are sorted last in alphabetical order. With the new app categories it maybe does not matter that much, no scrolling is currently needed.
  • zathura-vm should be renamed to something more descriptive.
image

@vunnyso
Copy link
Copy Markdown
Collaborator

vunnyso commented Mar 3, 2026

I second that, [flatpak] App Store is good option or even (flatpak) App Store seems to be fine. Adding a prefix helps with sorting, and removing the vm frees up additional space.

@kajusnau kajusnau marked this pull request as ready for review March 9, 2026 07:10
@kajusnau
Copy link
Copy Markdown
Collaborator Author

kajusnau commented Mar 9, 2026

Opening for review

It seems that the consensus from 2 comments and myself is that [vm] App format is the best.
Still open to suggestions, but we should decide if we move forward with this or not.

@kajusnau kajusnau changed the title evaluation: label virtual apps explicitly appvm: label virtual apps explicitly Mar 9, 2026
@kajusnau kajusnau marked this pull request as draft March 9, 2026 09:24
@kajusnau kajusnau marked this pull request as ready for review March 9, 2026 10:26
@kajusnau
Copy link
Copy Markdown
Collaborator Author

kajusnau commented Mar 9, 2026

Adjusted ghaf-open to:

  • Handle the new prefix (will be ignored), e.g.: ghaf-open Slack works as before
  • Handle automatic Wayland socket detection - no need to specify WAYLAND_DISPLAY when running ghaf-open

@vunnyso vunnyso self-requested a review March 9, 2026 12:35
@milva-unikie milva-unikie mentioned this pull request Mar 9, 2026
Merged
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Mar 9, 2026

Tested on Darter Pro

  • Labels don't work for Flatpak apps, they don't have labels in the app menu. Tested with Firefox and Spotify.
  • jenkins-pre-merge fails because the name of Outlook was changed, test-automation patch for that Update Outlook name ci-test-automation#718

@kajusnau
appvm: label virtual apps explicitly
c83b4ef 
Add prefix labels for all virtual apps' desktop entries,
indicating which VM they run in.
e.g. "[comms] Slack"

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Mar 10, 2026

Tested on Darter Pro

  • Looks good to me now!
  • All virtual apps including the flatpak apps have the correct label

I need to merge test changes with this @brianmcgillion

@TanelDettenborn
Copy link
Copy Markdown
Contributor

TanelDettenborn commented Mar 10, 2026 •
edited
Loading

I do not have a strong opinion about displaying prefixes, but perhaps it would be a bit more eye pleasing if prefixes would be newlined and centered?

--------------
|   <icon>   |
|    app     | 
|  (prefix)  |
--------------

@kajusnau
Copy link
Copy Markdown
Collaborator Author

kajusnau commented Mar 11, 2026

I do not have a strong opinion about displaying prefixes, but perhaps it would be a bit more eye pleasing if prefixes would be newlined and centered?

--------------
|   <icon>   |
|    app     | 
|  (prefix)  |
--------------

Not a bad suggestion, but it comes at the cost of maintaining yet another patch for upstream COSMIC.
Also, the suggestion you added here has a suffix, not a prefix 😀

@brianmcgillion brianmcgillion merged commit af57ec2 into tiiuae:main Mar 11, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@vunnyso vunnyso vunnyso approved these changes

@milva-unikie milva-unikie Awaiting requested review from milva-unikie

@clayhill66 clayhill66 Awaiting requested review from clayhill66

Assignees

@kajusnau kajusnau

Labels

Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kajusnau @milva-unikie @vunnyso @TanelDettenborn @brianmcgillion