Skip to content

partitioning: avoid blocking initrd TTY during TPM2 unlock handoff#1764

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-fixTPMdelay
Feb 18, 2026
Merged

partitioning: avoid blocking initrd TTY during TPM2 unlock handoff#1764
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-fixTPMdelay

Conversation

@vunnyso
Copy link
Copy Markdown
Collaborator

@vunnyso vunnyso commented Feb 17, 2026 •
edited
Loading

Description of Changes

Start systemd-cryptsetup non-blocking to fix delayed TPM2 PIN input

Fixes: https://jira.tii.ae/browse/SSRCSP-8004

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Verify https://jira.tii.ae/browse/SSRCSP-8004

@vunnyso
partitioning: avoid blocking initrd TTY during TPM2 unlock handoff
ee14e2b 
Start systemd-cryptsetup non-blocking to fix delayed TPM2 PIN input

Signed-off-by: Vunny Sodhi <vunny.sodhi@unikie.com>
@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Feb 18, 2026
@brianmcgillion
Copy link
Copy Markdown
Collaborator

brianmcgillion commented Feb 18, 2026

@Gaya-03 can you please review? this is the similar that was tried to be fixed last week.

@Gaya-03
Copy link
Copy Markdown
Collaborator

Gaya-03 commented Feb 18, 2026 •
edited
Loading

Checked on the following combination
Dater Pro
tmp2 on release image and debug
fido2 on release image
There is no delay observed while entering the TMP2 pin and encryption pin when required . There is no stuck on ghaf screen issue observed even after several reboots.

Lenovo-x1
tmp2 on release image
fido2 on release image

there was no delay observed while entering the Encryption Pin , however only in lenovo after entering the pin the laptop gets stuck in ghaf logo screen and does not go further . Maybe this can be investigated as part of https://jira.tii.ae/browse/SSRCSP-8003 which is still open

@Gaya-03 Gaya-03 added Tested on System76 and removed Needs Testing CI Team to pre-verify labels Feb 18, 2026
@brianmcgillion brianmcgillion merged commit 940ab0b into tiiuae:main Feb 18, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@mbssrc mbssrc Awaiting requested review from mbssrc

@Gaya-03 Gaya-03 Awaiting requested review from Gaya-03

Assignees

No one assigned

Labels

Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vunnyso @brianmcgillion @Gaya-03