net-vm: add net-vm features module#1763
Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom Feb 17, 2026
Merged
Conversation
- added net-vm features namespace - added missing hw passthrough config to net-vm via feature - fixes an issue where wlan name might be incorrect Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
|
Tested on Darter Pro (new image)
|
nesteroff
approved these changes
Feb 17, 2026
Contributor
nesteroff
left a comment
There was a problem hiding this comment.
Nice fix. At some point, we should refactor the services that use the hardcoded NIC name and remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
config.ghaf.hardware.definition.network.pciDevices.name, which is usually handled by a udev rule inmodules/hardware/common/devices.nixSince the major refactor, the config from
modules/hardware/common/devices.nixwas only applied to gui and audio VMs, not net VM.This patch re-introduces the net-vm config from
modules/hardware/common/devices.nixto net-vm via a feature moduleType of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify:
ifconfigIf it's working properly, the wlan interface name should be wlp0s5f0 on devices with Intel NICs (most of our laptop targets)
If it's not working properly, the wlan interface name will default to wlp0s1