Skip to content

net-vm: add net-vm features module#1763

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:netvm-features
Feb 17, 2026
Merged

net-vm: add net-vm features module#1763
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:netvm-features

Conversation

@kajusnau
Copy link
Copy Markdown
Collaborator

Description of Changes

  • Added net-vm features namespace
  • Added missing HW passthrough config to net-vm via feature
  • Fixes an issue where wlan name might be incorrect
    • Some Ghaf services expect the wlan name to be set correctly based on config.ghaf.hardware.definition.network.pciDevices.name, which is usually handled by a udev rule in modules/hardware/common/devices.nix
      Since the major refactor, the config from modules/hardware/common/devices.nix was only applied to gui and audio VMs, not net VM.
      This patch re-introduces the net-vm config from modules/hardware/common/devices.nix to net-vm via a feature module

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. We can verify the config is applied correctly by inspecting the wlan interface name in net-vm via ifconfig
    If it's working properly, the wlan interface name should be wlp0s5f0 on devices with Intel NICs (most of our laptop targets)
    If it's not working properly, the wlan interface name will default to wlp0s1

- added net-vm features namespace
- added missing hw passthrough config to net-vm via feature
- fixes an issue where wlan name might be incorrect

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
Copy link
Copy Markdown
Collaborator

@vunnyso vunnyso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milva-unikie
Copy link
Copy Markdown

Tested on Darter Pro (new image)

  • Wlan interface name is wlp0s5f0
  • All basic network tests pass

@milva-unikie milva-unikie added Tested on System76 and removed Needs Testing CI Team to pre-verify labels Feb 17, 2026
Copy link
Copy Markdown
Contributor

@nesteroff nesteroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. At some point, we should refactor the services that use the hardcoded NIC name and remove it.

Copy link
Copy Markdown
Collaborator

@brianmcgillion brianmcgillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@brianmcgillion brianmcgillion merged commit c7b33e6 into tiiuae:main Feb 17, 2026
32 checks passed
@kajusnau kajusnau deleted the netvm-features branch February 18, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants