Skip to content

fix(givc): stats manager bug#1696

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
mbssrc:fix-stats
Jan 21, 2026
Merged

fix(givc): stats manager bug#1696
brianmcgillion merged 1 commit intotiiuae:mainfrom
mbssrc:fix-stats

Conversation

@mbssrc
Copy link
Copy Markdown
Collaborator

@mbssrc mbssrc commented Jan 21, 2026

Description of Changes

Fix concurrent write bug in statsmanager.

Trigger the bug without this patch:

  • boot, login
  • ssh into chrome-vm
sudo su

for _ in $(seq 1 1000); do
    grpcurl -cacert /etc/givc/ca-cert.pem -cert /etc/givc/cert.pem -key /etc/givc/key.pem chrome-vm:9000 stats.StatsService/GetStats > /dev/null 2>&1 &
done

Then run journalctl -f to see agent failing.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. ...

Fix concurrent write bug in statsmanager.

Signed-off-by: Manuel Bluhm <manuel@ssrc.tii.ae>
@brianmcgillion brianmcgillion merged commit ee58882 into tiiuae:main Jan 21, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants