Skip to content

Improve PCI device auto-detection and enable it in the demo-tower target for network devices#1650

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
nesteroff:pci-autodetect
Dec 17, 2025
Merged

Improve PCI device auto-detection and enable it in the demo-tower target for network devices#1650
brianmcgillion merged 1 commit intotiiuae:mainfrom
nesteroff:pci-autodetect

Conversation

@nesteroff
Copy link
Copy Markdown
Contributor

@nesteroff nesteroff commented Dec 17, 2025

Description of Changes

  • Removed hardcoded GPU from the intel-laptop target and enabled cold-plugging of PCI devices by generating QEMU arguments in vhotplug and passing them to QEMU via microvm.extraArgsScript.
  • Enabled network PCI device auto-detection in the demo-tower target.
  • Updated vhotplug to a version with a fixed killswitch bug.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  • The Ghaf killswitch persistently issue should now be fixed.
  • No new changes to intel-laptop target but it should still now boot correctly on all laptops supported by Ghaf without a GPU being hardcoded in the code.
  • The new demo tower with a different ethernet adapter should have it passed through to the NetVM using PCI auto-detection in vhotplug. This will only work if there are no other devices in the same IOMMU group.

@nesteroff nesteroff changed the title Improve PCI device auto-detection and enabled it in the demo-tower target for network devices Improve PCI device auto-detection and enable it in the demo-tower target for network devices Dec 17, 2025
@nesteroff nesteroff marked this pull request as ready for review December 17, 2025 08:25
@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Dec 17, 2025
Signed-off-by: Yuri Nesterov <yuriy.nesterov@unikie.com>
@milva-unikie
Copy link
Copy Markdown

Tested on Darter Pro (nixos-rebuild switch)

  • Killswitch is persistent between boots again
  • USB camera and USB headsets work

Tested on intel-laptop-debug

  • Boots on Lenovo X1 gen 11
  • Very basic functionalities work

@milva-unikie milva-unikie added Tested on System76 and removed Needs Testing CI Team to pre-verify labels Dec 17, 2025
@brianmcgillion brianmcgillion merged commit f27172e into tiiuae:main Dec 17, 2025
32 checks passed
@nesteroff nesteroff deleted the pci-autodetect branch December 17, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants