Skip to content

GhA: stop building in github runners#1631

Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom
henrirosten:dont-build-devshell-in-eval
Dec 11, 2025
Merged

GhA: stop building in github runners#1631
brianmcgillion merged 2 commits intotiiuae:mainfrom
henrirosten:dont-build-devshell-in-eval

Conversation

@henrirosten
Copy link
Copy Markdown
Collaborator

@henrirosten henrirosten commented Dec 11, 2025

Description of Changes

Stop building ghaf devshell in github-hosted runners and move the pre-commit checks and ghaf shell builds to build.yml.

Before this change eval.yml ran nix develop --command .github/eval.sh ... which would to build the full ghaf devshell in a github-hosted runner.
Similarly, check.yml built checks.x86_64-linux.pre-commit in a github runner.
Building such targets in github-hosted runners is slow and might fail, due to the very limited resource in the github-hosted runners (and due to patches we might carry in github:tiiuae/nixpkgs that could trigger big re-builds).

This PR changes the eval.yml so that it does not build the full ghaf devshell, but runs the eval.sh in a custom shell including only the binaries the script requires (jq, nix-eval-jobs). In addition, this change moves the pre-commit checks and devshell build to the build.yml, which runs the builds on our remote builders that have sufficient resources. Additional benefit from these changes is: we now also push the ghaf devshell to ghaf-dev cachix cache.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. ...

Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
@henrirosten henrirosten force-pushed the dont-build-devshell-in-eval branch from 88c0fee to 38a7e84 Compare December 11, 2025 10:52
@henrirosten henrirosten marked this pull request as ready for review December 11, 2025 11:05
@henrirosten henrirosten changed the title GhA: stop building devshell in github runner on eval GhA: stop building in github runners Dec 11, 2025
@brianmcgillion brianmcgillion merged commit c6377a4 into tiiuae:main Dec 11, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants