Skip to content

cosmic: add pre-defined layouts and layout config#1617

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:fix-layout
Dec 9, 2025
Merged

cosmic: add pre-defined layouts and layout config#1617
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:fix-layout

Conversation

@kajusnau
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau commented Dec 5, 2025

Description of Changes

Added "Top Panel and Bottom Dock" and "Bottom Panel" layouts:

  • these layouts can be selected in the initial setup dialog
  • layout configuration options added to modules/desktop/graphics/cosmic/default.nix

Fixes an issue where selecting one of the two layouts in the initial setup would reset Ghaf cosmic config, particularly applets in the panel.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Install a fresh image or simply remove gui-vm's ~/.config
  2. In Ghaf, run cosmic-initial-setup manually or by booting a fresh image
  3. Proceed to the "Layout configuration" page
  4. In the layouts page, select either of the two layouts - changes should apply properly, ghaf-specific applets (killswitch, bluetooth, etc.) should remain accessible in both layouts.

Note: "Bottom Panel" layout feedback welcome - we can freely adjust the size, applets, and positions.

@milva-unikie
Copy link
Copy Markdown

Tested on Lenovo X1 (nixos-rebuild switch, removed ~/.config from the gui-vm)

Overall, the bottom panel layout works and matches Ghaf theme.

Since feedback was requested, here is what I would change:

  • Move the Applications icon to be the first icon on the left for consistency.
  • Either hide the Launcher in the bottom panel or add it to the top panel. I’d vote on hiding it to avoid confusing users.
  • Reduce the applet icon size to match the top panel, they currently take up half of the panel.
image

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Dec 8, 2025
Copy link
Copy Markdown
Collaborator

@vunnyso vunnyso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wip can be removed from PR title.

- added pre-defined layouts which can be selected in initial setup
- added layout config options in cosmic config

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@kajusnau kajusnau changed the title WIP: cosmic initial setup layout + wip themes cosmic: add pre-defined layouts and layout config Dec 8, 2025
@kajusnau
Copy link
Copy Markdown
Collaborator Author

kajusnau commented Dec 8, 2025

Adjusted the bottom-panel layout based on Milla's feedback
Ready for review and/or merge ✔️

@milva-unikie
Copy link
Copy Markdown

I checked the updated version, looks good. Thanks Kajus!

@brianmcgillion brianmcgillion merged commit 2f350e7 into tiiuae:main Dec 9, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants