Storedisk size and ghaf-vms (to list status)#1614
Merged
brianmcgillion merged 3 commits intotiiuae:mainfrom Dec 4, 2025
Merged
Storedisk size and ghaf-vms (to list status)#1614brianmcgillion merged 3 commits intotiiuae:mainfrom
brianmcgillion merged 3 commits intotiiuae:mainfrom
Conversation
increase the disk image as it is just over the previous limit. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
3d2f944 to
6797473
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes several unrelated changes that don't align well with the title "Storedisk size":
- Primary change: Increases debug partition disk sizes (image from 60G to 70G, root partition from 40G to 50G)
- New tool: Adds a
ghaf-vmscommand-line tool to list MicroVM statuses - Removal: Removes the Losslesscut Video Editor from the business VM
The PR description is incomplete and doesn't explain the rationale for these changes.
Key Changes
- Increased storage allocations for debug builds to accommodate larger system requirements
- Added a new debugging tool for viewing MicroVM status with color-coded output
- Removed video editing capability from the business VM configuration
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/pkgs-by-name/ghaf-vms/package.nix | New shell script package for listing MicroVM status with color-coded output (running/stopped/failed) |
| packages/own-pkgs-overlay.nix | Registers the new ghaf-vms package in the overlay |
| modules/reference/appvms/business.nix | Removes Losslesscut video editor application entry |
| modules/partitioning/disko-debug-partition.nix | Increases total image size from 60G to 70G and root partition from 40G to 50G |
| modules/development/dt-host.nix | Adds ghaf-vms tool to host debugging tools for x86_64 systems |
6797473 to
32850fc
Compare
32850fc to
80fab90
Compare
This was referenced Dec 4, 2025
kajusnau
requested changes
Dec 4, 2025
Collaborator
kajusnau
left a comment
There was a problem hiding this comment.
Some details so the script matches what is said in the doc 🫡
Collaborator
|
Also maybe we could adjust the PR name so both disk changes and |
80fab90 to
d6c1c43
Compare
Adds functionality to host to query the status of the vms that are on the system. When using the storeOnDisk option, there is no link created to the current system so the `microvm -l` will not work and just stops. Ensure that it is possible to see at a glance which vm is actually running/stopped. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
d6c1c43 to
bba2615
Compare
kajusnau
approved these changes
Dec 4, 2025
vunnyso
reviewed
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: