Skip to content

givc: bump to include fix for shutdown hang#1610

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:reboot-time-workaround
Dec 3, 2025
Merged

givc: bump to include fix for shutdown hang#1610
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:reboot-time-workaround

Conversation

@kajusnau
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau commented Dec 3, 2025

Description of Changes

Bump for givc to include service adjustments that prevent system from hanging on shutdown.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Rebuild Ghaf and boot
  2. (Optional) Inspect (systemctl cat <service>) some or all of the following services and confirm they all match these values:
    • Match:
      Type = "exec";
      Restart = "on-failure";
      TimeoutStopSec = 5;
    • Services:
      host:
        givc-ghaf-host.service
      admin-vm:
        givc-admin.service
      system vms:
        givc-<VM-NAME>.service
      
      Some other services are affected as well, like dbus-proxy and ota-update-server
  3. Verify https://jira.tii.ae/browse/SSRCSP-7668 is fixed.

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@kajusnau
Copy link
Copy Markdown
Collaborator Author

kajusnau commented Dec 3, 2025

Added a small change to revert debug partition image size changes done in https://github.com/tiiuae/ghaf/pull/1562/files#diff-ab41d17b45112b9a0e1da4b77f5bb49b72e7b64a56fb8b579291ffebf9713f8aR55-R111

@mbssrc
Copy link
Copy Markdown
Collaborator

mbssrc commented Dec 3, 2025

Added a small change to revert debug partition image size changes done in https://github.com/tiiuae/ghaf/pull/1562/files#diff-ab41d17b45112b9a0e1da4b77f5bb49b72e7b64a56fb8b579291ffebf9713f8aR55-R111

You checked this works with storeOnDisk enabled?

@kajusnau
Copy link
Copy Markdown
Collaborator Author

kajusnau commented Dec 3, 2025

Added a small change to revert debug partition image size changes done in https://github.com/tiiuae/ghaf/pull/1562/files#diff-ab41d17b45112b9a0e1da4b77f5bb49b72e7b64a56fb8b579291ffebf9713f8aR55-R111

You checked this works with storeOnDisk enabled?

No. Done as instructed by @brianmcgillion 😇 Images are now smaller so we should be ok with previous size

@milva-unikie
Copy link
Copy Markdown

Tested on Lenovo X1 and Darter Pro

  • Long shut down time has been fixed.
  • With Darter Pro nixos-rebuild switch worked with no issues.
  • With Lenovo X1 there was an issue where only the gui-vm would shut down after using nixos-rebuild to update. With a new installation X1 is also working.

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76 labels Dec 3, 2025
@brianmcgillion brianmcgillion merged commit e4b979e into tiiuae:main Dec 3, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants