iso: do not copy the system closure only the disk#1609
Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom Dec 2, 2025
Merged
iso: do not copy the system closure only the disk#1609brianmcgillion merged 1 commit intotiiuae:mainfrom
brianmcgillion merged 1 commit intotiiuae:mainfrom
Conversation
The iso was containing the disk image that is to be flashed to the target device along with the entire system closure. This is why the disk image of 6.4 GB (system76 darter pro) was causing an iso of 13GB to be created. Now we ensure not to copy the closure just the disk image. There is still room for improvement, but that will come in a follow up PR. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
mbssrc
approved these changes
Dec 2, 2025
This was referenced Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iso was containing the disk image that is to be flashed to the target device along with the entire system closure. This is why the disk image of 6.4 GB (system76 darter pro) was causing an iso of 13GB to be created.
Now we ensure not to copy the closure just the disk image. There is still room for improvement, but that will come in a follow up PR.
Description of Changes
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: