Merged
Conversation
Remove the default inclusion of FW into all target vms by default. Only enable the feature when needed. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
6a631c3 to
60cb219
Compare
kajusnau
approved these changes
Dec 2, 2025
Collaborator
kajusnau
left a comment
There was a problem hiding this comment.
Looks good at a glance, but should have this tested/sanity-checked to make sure nothing unexpected breaks 😬
60cb219 to
e92946c
Compare
vunnyso
reviewed
Dec 2, 2025
Put the test tools into the vms where they are actually needed. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
e92946c to
b410060
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: