feat(givc): enable notifier and exec#1596
Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom Dec 1, 2025
Merged
Conversation
Enable notifier module, and re-enable exec module on host only. The latter still enables RCE from anywhere to the host, and needs to be fixed. Signed-off-by: Manuel Bluhm <manuel@ssrc.tii.ae>
brianmcgillion
approved these changes
Dec 1, 2025
vunnyso
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Enable notifier module, and re-enable exec module on host only. The latter still enables RCE from anywhere
to the host, which needs to be fixed.
The notifier runs a socket-activated user service that can receive and display notifications for
logged in users from any VM or host via givc-cli. This can be used standalone, or in conjunction
with a notification proxy for generic forwarding. Alternatively, the latter can be achieved by
connecting dbus user sessions.
Example (e.g. from admin-vm):
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: