Skip to content

Refactor cleanup#1594

Merged
brianmcgillion merged 7 commits intotiiuae:mainfrom
brianmcgillion:refactor-cleanup
Dec 1, 2025
Merged

Refactor cleanup#1594
brianmcgillion merged 7 commits intotiiuae:mainfrom
brianmcgillion:refactor-cleanup

Conversation

@brianmcgillion
Copy link
Copy Markdown
Collaborator

@brianmcgillion brianmcgillion commented Nov 30, 2025 •
edited
Loading

Description of Changes

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. It is mostly a cleanup PR. So the standard test set should pass

@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Nov 30, 2025
@brianmcgillion
profiles: consolidate profiles
0f226ad 
Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion
hydraJobs: remove,we dont support hydra builds
5c3580b 
Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion
polarFire: Remove the polarfire - not maintained
47bc3e3 
Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Dec 1, 2025

Tested on Darter Pro (new image)

  • SSH does not work
[ghaf@ghaf-0653519555:~]$ ssh ghaf-host
-bash: ssh: command not found
  • That makes checking everything else hard. Would be nice to get that one fixed first.

@milva-unikie milva-unikie added Bug on System76 and removed Needs Testing CI Team to pre-verify labels Dec 1, 2025
kajusnau
kajusnau requested changes Dec 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice purge 🧹
Some other notes in addition to my comments:

  • modules/reference/desktop/applications.nix and modules/reference/appvms/business.nix:
    both have checks for compositor != "cosmic", which, in practice, is a check for labwc.
    So those sections can likely be removed entirely.
  • Is there still a need for the ghaf.profiles.graphics.compositor option?
    I can see why it may be useful to keep in case we decide to add support for another compositor in the future.
    But then again, it's a fairly simple thing to add if needed, and now it serves no purpose.

kajusnau
kajusnau approved these changes Dec 1, 2025
View reviewed changes
@brianmcgillion
labwc: REMOVE, no longer maintained
bb67f04 
Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion
minimal profile: start defining a minimal profile
d8b3428 
Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion
lib: remove icons.nix and use launcher in main lib
8564a2d 
The functions in icon.nix are unused so removed. The `rmDesktopEntries`
function was being imported by file path where ever it was used. This
change now exports it as part of the lib for easier access.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion
element-web: appears to be unused in the current setup
e2bf1ce 
removing unused package.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Dec 1, 2025

Tested on Darter Pro (nixos-rebuild switch)

All good now! Automated tests are passing and no issues found in a short manual regression test.

brianmcgillion
brianmcgillion commented Dec 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@brianmcgillion brianmcgillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@brianmcgillion brianmcgillion merged commit 2252a41 into tiiuae:main Dec 1, 2025
30 checks passed
@brianmcgillion brianmcgillion deleted the refactor-cleanup branch December 1, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kajusnau kajusnau kajusnau approved these changes

Assignees

No one assigned

Labels

Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianmcgillion @milva-unikie @kajusnau