Skip to content

modules/partitioning: fix disko builder permission error#1588

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
vadika:fix/disko-builder-xcp
Nov 26, 2025
Merged

modules/partitioning: fix disko builder permission error#1588
brianmcgillion merged 1 commit intotiiuae:mainfrom
vadika:fix/disko-builder-xcp

Conversation

@vadika
Copy link
Copy Markdown
Contributor

@vadika vadika commented Nov 25, 2025 •
edited
Loading

Description of Changes

xcp opens more files than virtiofs can handle, also there is a "[2025-11-26T08:21:44Z WARN virtiofsd::limits] Failure when trying to set the limit to 1000000, the hard limit (524288) of open file descriptors is used instead." message in the logs.
Solution is to limit the parallelness of xcp.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

Bulds should not fail

@vadika vadika force-pushed the fix/disko-builder-xcp branch from 8888172 to d1f813a Compare November 25, 2025 14:38
@vadika vadika force-pushed the fix/disko-builder-xcp branch from d1f813a to 30b65fc Compare November 25, 2025 15:11
@vadika vadika force-pushed the fix/disko-builder-xcp branch from 30b65fc to 87e03de Compare November 25, 2025 15:48
@vadika vadika marked this pull request as draft November 25, 2025 18:11
@milva-unikie

This comment was marked as outdated.

Sign in to view
@vadika
Copy link
Copy Markdown
Contributor Author

vadika commented Nov 26, 2025

jenkins-pre-merge pipeline found one issue, logrotate-checkconf.service is failing in all VMs for all laptops

Nov 25 16:11:14 gui-vm systemd[1]: Starting Logrotate configuration check...
Nov 25 16:11:14 gui-vm logrotate[650]: warning: logrotate in debug mode does nothing except printing debug messages!  Consider using verbose mode (-v) instead if this is not what you want.
Nov 25 16:11:14 gui-vm logrotate[650]: error: Ignoring /nix/store/06q2sc20987fxik6y0mzsflkgbzvd7kb-logrotate.conf because the file owner is wrong (should be root or user with uid 0).
Nov 25 16:11:14 gui-vm logrotate[650]: Reading state from file: /var/lib/logrotate.status
Nov 25 16:11:14 gui-vm logrotate[650]: state file /var/lib/logrotate.status does not exist
Nov 25 16:11:14 gui-vm logrotate[650]: Allocating hash table for state file, size 64 entries
Nov 25 16:11:14 gui-vm logrotate[650]: Handling 0 logs
Nov 25 16:11:14 gui-vm systemd[1]: logrotate-checkconf.service: Main process exited, code=exited, status=1/FAILURE
Nov 25 16:11:14 gui-vm systemd[1]: logrotate-checkconf.service: Failed with result 'exit-code'.
Nov 25 16:11:14 gui-vm systemd[1]: Failed to start Logrotate configuration check.

This is not a working fix, unfortunately :(

@vadika vadika force-pushed the fix/disko-builder-xcp branch from 87e03de to 49c4b49 Compare November 26, 2025 08:52
@vadika
Copy link
Copy Markdown
Contributor Author

vadika commented Nov 26, 2025

Fix is working, but IMO fixed the symptom, not the cause.

@vadika vadika marked this pull request as ready for review November 26, 2025 10:23
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Nov 26, 2025

Can we merge this @brianmcgillion? The build issue is blocking almost all other PRs.

@vadika
modules/partitioning: fix disko builder permission error
dfcdbdc 
error is caused by number of open files is bigger than virtiofs can
handle.

Signed-off-by: vadik likholetov <vadikas@gmail.com>
@milva-unikie milva-unikie mentioned this pull request Nov 26, 2025
Merged
19 tasks
@vadika vadika force-pushed the fix/disko-builder-xcp branch from 49c4b49 to dfcdbdc Compare November 26, 2025 12:47
@vadika
Copy link
Copy Markdown
Contributor Author

vadika commented Nov 26, 2025 •
edited
Loading

Hypothesis -- xcp opens more files than virtiofs can handle, also there is a "[2025-11-26T08:21:44Z WARN virtiofsd::limits] Failure when trying to set the limit to 1000000, the hard limit (524288) of open file descriptors is used instead." message in the logs. Cleaner solution is to limit the parallelness of xcp.

@brianmcgillion
Copy link
Copy Markdown
Collaborator

brianmcgillion commented Nov 26, 2025

Thanks @vadika for digging into this one!!

@brianmcgillion brianmcgillion merged commit d3b3ff3 into tiiuae:main Nov 26, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vadika @milva-unikie @brianmcgillion