Skip to content

cosmic-applets: hide some buttons#1580

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:cosmic-adjust
Nov 25, 2025
Merged

cosmic-applets: hide some buttons#1580
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:cosmic-adjust

Conversation

@kajusnau
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau commented Nov 24, 2025 •
edited
Loading

  1. audio-applet: added a patch to hide "Sound settings..." button
    • Needed to avoid opening cosmic-settings with audio-vm's system DBUS address
  2. bluetooth-applet: added a patch to hide "Bluetooth settings..." button
    • Needed to avoid opening cosmic-settings with audio-vm's system DBUS address
  3. network-applet: added a patch to hide "Airplane Mode" toggle

For 1. and 2. - these patches should be removed as soon as dbus-proxy supports audio and bluetooth

Description of Changes

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Verify COSMIC Audio applet does no longer does not have the "Sound settings..." button at the bottom
  2. Verify COSMIC Network applet does not have the "Airplane Mode" toggle at the top

@kajusnau
cosmic-applets: hide some buttons
d52f6fd 
- audio-applet: patch to hide sound settings button
- bluetooth-applet: patch to hide bluetooth settings button
- network-applet: patch to hide airplane mode toggle

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@kajusnau kajusnau self-assigned this Nov 24, 2025
@kajusnau kajusnau added the Needs Testing CI Team to pre-verify label Nov 24, 2025
@kajusnau kajusnau mentioned this pull request Nov 24, 2025
Merged
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Nov 24, 2025

Dell 7230 build fails in the jenkins-pre-merge. I tried re-triggering the build multiple times, but it keeps failing every time. This same issue was happening earlier today with a different PR, but it started building after six attempts. If there are no other solutions I can try to re-trigger this one a few more times tomorrow.

Tested on Lenovo X1 (nixos-rebuild switch)

Sound settings and airplane mode have been hidden.

@milva-unikie milva-unikie added bug Something isn't working Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Nov 24, 2025
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Nov 25, 2025

Dell 7230 build is working now!

@milva-unikie milva-unikie removed the bug Something isn't working label Nov 25, 2025
@brianmcgillion brianmcgillion merged commit 219ba3d into tiiuae:main Nov 25, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@vunnyso vunnyso vunnyso approved these changes

Assignees

@kajusnau kajusnau

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kajusnau @milva-unikie @brianmcgillion @vunnyso