Skip to content

cosmic: enable nm in login, replace nm-applet with cosmi's builtin#1575

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:cosmic-adjust
Nov 21, 2025
Merged

cosmic: enable nm in login, replace nm-applet with cosmi's builtin#1575
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:cosmic-adjust

Conversation

@kajusnau
Copy link
Copy Markdown
Collaborator

Description of Changes

  1. Added back network manager functionality to cosmic-greeter (login and lock screen)
  2. Removed nm-applet in favor of COSMIC's built-in Network applet

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Boot into Ghaf and verify login screen has a network icon
  2. Verify lock screen also has a network icon
  3. Evaluate the usability of COSMIC's built-in Network applet (top right)

@kajusnau kajusnau self-assigned this Nov 20, 2025
@kajusnau kajusnau marked this pull request as ready for review November 20, 2025 12:51
@kajusnau kajusnau added the Needs Testing CI Team to pre-verify label Nov 20, 2025
@vunnyso
Copy link
Copy Markdown
Collaborator

vunnyso commented Nov 20, 2025

Probably can remove package from https://github.com/tiiuae/ghaf/blob/main/modules/microvm/sysvms/guivm.nix#L211

@brianmcgillion
Copy link
Copy Markdown
Collaborator

the only commentary that I can make at the moment is that the "network settings" take quite a while to show. when clicked. it is almost 10 seconds. I am not sure if this is because of some dbus round trip to the netvm and back.

@kajusnau
Copy link
Copy Markdown
Collaborator Author

the only commentary that I can make at the moment is that the "network settings" take quite a while to show. when clicked. it is almost 10 seconds. I am not sure if this is because of some dbus round trip to the netvm and back.

Clicking "Network settings..." in the applet opens the Network page in the Settings app.
The real issue is the Settings app taking a long time to load, not necessarily the network settings. As for the cause... Maybe an I/O limit? CPU usage is really not a concern.

I would argue that 90% of users will probably just connect to a wireless network or enable/disable wireless, which can both be done in the applet 😀 I'm open to discussions on this

… builtin

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@leivos-unikie
Copy link
Copy Markdown
Contributor

leivos-unikie commented Nov 21, 2025

Tested on Orin AGX (with cross-compiled image)

  • Both login screen and lock screen have network icon (it appears to be smaller than the one in desktop taskbar, a bit too small in my opinion but maybe on Orins it doesn't matter so much)
  • Probably test step 3 does not apply to Orins? Should COSMIC built-in Network applet be also available on Orin (ghaf-host) desktop? If I add Network icon to taskbar via COSMIC Setting and click it menu shows Network settings but that leads to Network & Wireless in COSMIC Setup and there is only VPN setup...

@leivos-unikie leivos-unikie added the Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled label Nov 21, 2025
Copy link
Copy Markdown
Collaborator

@vunnyso vunnyso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, Improving the filesystem used for our VMs and optimizing the IO operations can eventually help COSMIC Settings , applets and overall system performance.

@vunnyso
Copy link
Copy Markdown
Collaborator

vunnyso commented Nov 21, 2025

Just a tip to avoid fresh installation:

Go to "Cosmic Settings" --> Desktop --> Panel -> "Reset to default" (at bottom)

@brianmcgillion brianmcgillion merged commit 28e6963 into tiiuae:main Nov 21, 2025
28 checks passed
@brianmcgillion
Copy link
Copy Markdown
Collaborator

sorry sorry. I saw green and it has been so longe since I clicked merge, my finger just hit it

@Gaya-03
Copy link
Copy Markdown
Collaborator

Gaya-03 commented Nov 21, 2025

Tested on Dater Pro.

  • I agree with Samuli the icon on the login and lock screen is rather small . It can be made a bit bigger. The network icon is working fine otherwise

For Test step 3 :

  • Airplane mode when enabled gets disabled on its own. It cuts the Wi-Fi but user can turn it on as the Airplane mode get disabled on its own. Bluetooth connected still remains connected throughout the airplane mode enable-disable.

  • Add network open editing connection window. Is it intentionally kept to one option to edit and make new connections including hidden wifi ?

  • Previously there was 'Connection Information' option present in the drop down It used to have quick information access about Hardware Address, speed, driver, iPv4 and iPv6 information.
    With the new change if we want to see all the connection information, you need to go to Network & wireless settings ->choose the wifi-> settings and navigate multiple tabs to get the information.
    Maybe useful to have the connection information tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug on System76 Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled Tested on System76

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants