Fix printf octal interpretation error in hostname generation#1566
Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom Nov 17, 2025
Merged
Fix printf octal interpretation error in hostname generation#1566brianmcgillion merged 1 commit intotiiuae:mainfrom
brianmcgillion merged 1 commit intotiiuae:mainfrom
Conversation
fa90c28 to
aca410d
Compare
When the generated ID starts with 0 (e.g., 0990473387), printf '%x' interprets it as an octal number, causing 'invalid octal number' error since 09 is not valid in octal (only 0-7 digits allowed). Force base-10 interpretation using $((10#$id)) to prevent this corner case. Signed-off-by: vadik likholetov <vadikas@gmail.com>
aca410d to
6bf6074
Compare
vunnyso
approved these changes
Nov 17, 2025
|
I checked from the jenkins-pre-merge pipeline that All other targets are working as well. |
brianmcgillion
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the generated ID starts with 0 (e.g., 0990473387), printf '%x' interprets it as an octal number, causing 'invalid octal number' error since 09 is not valid in octal (only 0-7 digits allowed).
Force base-10 interpretation using $((10#id)) to prevent this corner case.
Description of Changes
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: