Skip to content

fix(xdg-handlers): manage appuser mimeapps.list via systemd tmpfiles#1559

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
enesoztrk:fix/xdg-url-handler-2
Nov 13, 2025
Merged

fix(xdg-handlers): manage appuser mimeapps.list via systemd tmpfiles#1559
brianmcgillion merged 1 commit intotiiuae:mainfrom
enesoztrk:fix/xdg-url-handler-2

Conversation

@enesoztrk
Copy link
Copy Markdown
Contributor

@enesoztrk enesoztrk commented Nov 12, 2025 •
edited
Loading

Use systemd.tmpfiles to declaratively ensure ~/.config/mimeapps.list is always symlinked to /etc/xdg/mimeapps.list for the app user.

Description of Changes

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

SSRCSP-7540

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Follow the test steps : SSRCSP-7540
  2. Check mimetypes (URL, image, PDF) still work for every VM

@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Nov 12, 2025
@leivos-unikie
Copy link
Copy Markdown
Contributor

leivos-unikie commented Nov 12, 2025

I am sorry, launched new (manual) pre-merge test run for this PR in dev jenkins and didn't remember to uncheck the box "SET_PR_STATUS". (Intention was to test pipeline not this PR.)

The previous pre-merge run of this PR passed fine
https://ci-prod.vedenemo.dev/job/ghaf-pre-merge/765/

@leivos-unikie
Copy link
Copy Markdown
Contributor

leivos-unikie commented Nov 12, 2025 •
edited
Loading

Tested on Lenovo-X1

  • Opening Element Sign in to comms-vm chrome window worked at first but then stopped working after I had done some other testing, e.g. opening restricted url from trusted browser to chrome-vm by clicking the browser ghaf icon.
  • Now comms-vm journalctl shows
Nov 12 12:59:27 comms-vm run-waypipe[801]: [801:1112/125927.477380:INFO:CONSOLE:1] "element-web closing", source: vector://vector/webapp/bundles/36b43e50a7cfc7b9ed5c/init.js (1)
Nov 12 12:59:28 comms-vm run-waypipe[1980]: [1975:1975:1112/125928.323758:ERROR:ui/ozone/platform/x11/ozone_platform_x11.cc:249] Missing X server or $DISPLAY
Nov 12 12:59:28 comms-vm run-waypipe[1980]: [1975:1975:1112/125928.323792:ERROR:ui/aura/env.cc:257] The platform failed to initialize.  Exiting.

when clicking "Continue" button in Element app Sign in page.

comms-vm_journalctl.log

EDIT:
Found out the cause. When I opened Zoom, signed that in, signed out, and closed, Element Sign in "Continue" button stopped working.

@leivos-unikie leivos-unikie added bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR and removed Needs Testing CI Team to pre-verify labels Nov 12, 2025
@enesoztrk
fix(xdg-handlers): manage appuser mimeapps.list via systemd tmpfiles
8349412 
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
@enesoztrk enesoztrk force-pushed the fix/xdg-url-handler-2 branch from 1561c78 to 8349412 Compare November 13, 2025 06:52
@enesoztrk enesoztrk changed the title fix(xdg-handlers): remove duplicated mimeapps.list files to prevent x… fix(xdg-handlers): manage appuser mimeapps.list via systemd tmpfiles Nov 13, 2025
@enesoztrk enesoztrk added Needs Testing CI Team to pre-verify and removed bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR labels Nov 13, 2025
@leivos-unikie
Copy link
Copy Markdown
Contributor

leivos-unikie commented Nov 13, 2025

Tested on Lenovo-x1 that now Element Sign in buttons work well and are not distracted by Zoom or Slack.

Opening mimetypes: url links, images, pdfs from VMs seem to work also.

@leivos-unikie leivos-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Nov 13, 2025
@brianmcgillion brianmcgillion merged commit 1f425ed into tiiuae:main Nov 13, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@vunnyso vunnyso Awaiting requested review from vunnyso

Assignees

No one assigned

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enesoztrk @leivos-unikie @brianmcgillion