Prevent running authorized actions in empty environment#1556
Merged
brianmcgillion merged 1 commit intomainfrom Nov 11, 2025
Merged
Conversation
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
brianmcgillion
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fail the github action authorization step if the '
ENV_DEFINED' variable is not set in the environment the github action workflow is running.This change prevents running authorized actions in an empty environment, which could happen due to misconfiguration such as; a typo in an environment name or accidental removal of the
internalorexternalgithub environments. This additional check is needed because github actions do not fail if one attempts to run an action in non-existent environment. Instead, in such a case github action would create an empty environment and continue the execution.This is defense-in-depth, trying to make the current github action configuration less prone to potentially fatal misconfigurations in the future.
warn-on-workflow-changes failure is expected since this PR modifies the file
.github/workflows/authorize.ymland it will pass again as soon as this PR is merged.Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: