Skip to content

Checks on push#1550

Merged
brianmcgillion merged 3 commits intotiiuae:mainfrom
brianmcgillion:checks-on-push
Nov 10, 2025
Merged

Checks on push#1550
brianmcgillion merged 3 commits intotiiuae:mainfrom
brianmcgillion:checks-on-push

Conversation

@brianmcgillion
Copy link
Copy Markdown
Collaborator

Description of Changes

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. ...

Adds a checker for the nixf-tidy tool that is part of nixd. It looks for
antipatterns in code.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
nixf-diagnose complains about the path shadowing path from buildins so
fix that issue in the launcher where is is complaining.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
use the full complement of pre-commit checks in the github actions.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion brianmcgillion merged commit d1aa424 into tiiuae:main Nov 10, 2025
28 checks passed
@brianmcgillion brianmcgillion deleted the checks-on-push branch November 10, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants