Conversation
|
Waiting for cloudflare issue to be resolved before re-running checks |
|
Nice work! |
Update:
|
|
Ready for testing, but QA is likely busy with release testing, so we may need to wait a while (or merge as is 👀) |
|
Is it possible to change the performance profile via command line? |
Generally it should be enough to change the profile in gui-vm, host and net-vm should change automatically. You can also list available profiles |
Ok. Thanks. I think those are enough to automate some tests later. So change of performance profile should propagate from gui-vm to host/net-vm. Does it work from host to net-vm/gui-vm? |
I have already written an automated test case for this :) We used it to create the graph in the description. I need to clean it up a bit first, but I’m planning to add it to our performance tests. |
No, only from gui-vm to others. |
|
Tested on Lenovo-X1 (
@mbssrc I have to strongly disagree with this. With performance mode the fans are extremely loud and disturb the peaceful office environment. I measured the boot time and it is not faster with this PR. The fans don't actually start going crazy during boot, they only start after the login screen has been visible for a while. Because the mode is forced to performance during boot this happens every time. I suggest changing the default mode back to balanced. My Darter Pro is used in the release testing currently, but I quickly borrowed Vunny's to check the fans. With Darter Pro the fans are not as noticeable. |
|
@milva-unikie That's why I prefixed it with "personally" :), and conditioned on that it actually makes the boot faster. I assume that the current bottleneck is mostly IO, based on what I measured a while back (which we can hopefully change in the future). That being said, I ran this on my system76 and it is silent, but I agree if it doesn't result in faster boot and hurts your ears let's keep it on balanced. |
- added ghaf performance module - added power profiles for host, gui-vm, net-vm, audio-vm - enabled power profile switching on all targets - enabled power profile propagation from gui-vm to host and net-vm - added s76-scheduler assignments for host and gui-vm for improved responsiveness Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
Update:
|
|
Tested on Darter Pro and Lenovo X1 ( Looks good, feels good, sounds good.
|
Great |
Description of Changes
Introduced a new performance module inspired by System76 Scheduler and TuneD.
This module replaces both power-profiles-daemon and system76-power, providing greater flexibility and allowing the definition of custom power profiles for both AC and battery modes in Ghaf.
With the addition of the module, Ghaf-specific power profiles are introduced as well, and are enabled by default for the host, based on the selected power profile (e.g. selecting powersave enables the ghaf-powersave profile).
Gui, net and audio VMs all use the upstream
virtual-guestprofile, which can be found here.Key Features
Current configuration
gui-vm, net-vm, other possible guests
{ power-saver = "virtual-guest"; balanced = "virtual-guest"; performance = "virtual-guest"; };virtual-guestdefault TuneD profile, with some extra functionality provided by scripts:host
{ power-saver = "ghaf-powersave"; balanced = "ghaf-balanced"; performance = "ghaf-performance"; };ghaf-*profiles are a mixture of the default profiles from system76-power and TuneD'svirtual-hostprofileNote: Battery and AC profiles are the same except for backlight adjustment - on battery, backlight adjustment is more aggressive.
Behavior
Real world performance
Thanks to @milva-unikie and @leivos-unikie, we now have a clear visualization of the impact of this change.
The table below shows two power-measurement graphs collected on a Lenovo X1 Gen 11.
Supported Targets
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify:
General:
tuned-adm activePerformance (Optional, perf tests can be done after merge):
Battery life: