The lsp made me do it#1540
Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom Nov 6, 2025
Merged
Conversation
nixd, through nixt and nixf highlights anti-patterns that should be addressed. Mainly with shadowing functions between the different namespaces, e.g. builtins and lib. The general rule is that you should be explicit, if the function exists in both scopes and not rely on inherit, to set the correct set. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
kajusnau
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nixd, through nixt and nixf highlights anti-patterns that should be addressed. Mainly with shadowing functions between the different namespaces, e.g. builtins and lib.
The general rule is that you should be explicit, if the function exists in both scopes and not rely on inherit, to set the correct set.
Description of Changes
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: