chrome-extensions: fetch pinned versions by default#1529
Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom Nov 4, 2025
Merged
chrome-extensions: fetch pinned versions by default#1529brianmcgillion merged 1 commit intotiiuae:mainfrom
brianmcgillion merged 1 commit intotiiuae:mainfrom
Conversation
vunnyso
reviewed
Nov 4, 2025
- use crx4chrome to fetch chrome extensions by default - added a check to verify fetched file contains a crx header Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
0c08a88 to
a182945
Compare
vunnyso
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
fixedVersionparameter tomkExtensiondefaults to
true, but can be overriden tofalseto use Chrome Web Store as the source insteadCr24orCrX3)With this change there should be no hash mismatches in the future unless we explicitly update the
versionof a given extension.This way we follow the general standard approach of updating nix packages:
Downgrading extensions is generally not possible, as chrome will check the
update.xmlversion and update only if the listed version is higher than the already installed extension's version./home/appuser/.config/google-chrome)What this essentially means is that our browsers' extensions will never be downgraded unless Ghaf is reinstalled completely, at which point it's just a normal installation rather than a "downgrade" 😃
About crx4chrome.com
Supports downloading extensions either from its own mirror or directly from the Chrome Web Store, with identical file hashes between both sources.
Maintains a long archive of older extension versions, in some cases dating back to 2016–2017, depending on the extension.
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
See description above
TL;DR: Rebuild for extension updates, re-install for downgrades
nixos-rebuild ... switchTest Steps To Verify:
As this is a packaging change, testing requires manually fiddling with our chrome extensions package
Scenario 1 - fetch a known older version of an extension
packages/chrome-extensions/default.nixand find thesession-buddyat line 112versionfield to a known older version, say4.0.3/home/appuser/.config/google-chrome) and launch Trusted Browser4.0.3Scenario 2 - update the extension (do Scenario 1 first)
packages/chrome-extensions/default.nixand find thesession-buddyat line 112versionfield to a known newer version, say4.0.54.0.5(chrome checks for updates periodically, so it may not be updated immediately)Alternative
packages/chrome-extensions/default.nix:modules/reference/appvms/business.nixpackages/chrome-extensions/default.nixto the latest version:1.67.0(chrome checks for updates periodically, so it may not be updated immediately)