Skip to content

Fix/xdg url handler#1519

Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom
enesoztrk:fix/xdg-url-handler
Nov 3, 2025
Merged

Fix/xdg url handler#1519
brianmcgillion merged 2 commits intotiiuae:mainfrom
enesoztrk:fix/xdg-url-handler

Conversation

@enesoztrk
Copy link
Copy Markdown
Contributor

@enesoztrk enesoztrk commented Nov 3, 2025 •
edited
Loading

Description of Changes

  • External URLs are opened inside the corresponding VM when either google-chrome or chromium is available
  • Disabling element-gps and dendrite apps

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

SSRCSP-7487
SSRCSP-7356

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Follow the steps outlined in SSRCSP-7356
  2. The login screen should open in the google-chrome browser on comms-vm.
  3. Test element-desktop functionalities such as text chat, voice/audio chat

@enesoztrk
xdg-handlers: correct external URL handling
6f87646 
* External URLs are opened inside the corresponding VM when either google-chrome or chromium is available

Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
@enesoztrk
element-desktop: disabling dendrite and element-gps services
dec36d0 
Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
@enesoztrk enesoztrk marked this pull request as ready for review November 3, 2025 10:16
@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Nov 3, 2025
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Nov 3, 2025

Tested on Darter Pro (new image)

  • Element login works, even when Slack is open. It now uses the comms-vm browser to log in.
  • Element app works.

@milva-unikie milva-unikie added Tested on System76 and removed Needs Testing CI Team to pre-verify labels Nov 3, 2025
@brianmcgillion brianmcgillion merged commit 2cd5f9f into tiiuae:main Nov 3, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vunnyso vunnyso vunnyso approved these changes

@brianmcgillion brianmcgillion Awaiting requested review from brianmcgillion

Assignees

No one assigned

Labels

Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@enesoztrk @milva-unikie @vunnyso @brianmcgillion