Skip to content

Disable alerts on dangerous trigger#1515

Merged
brianmcgillion merged 2 commits intomainfrom
disable-alerts-on-dangerous-trigger
Oct 29, 2025
Merged

Disable alerts on dangerous trigger#1515
brianmcgillion merged 2 commits intomainfrom
disable-alerts-on-dangerous-trigger

Conversation

@henrirosten
Copy link
Copy Markdown
Collaborator

@henrirosten henrirosten commented Oct 29, 2025

Description of Changes

Disable alerts on the GitHub code scanning dashboard that stem from using the pull_request_target trigger:

The current usage of pull_request_target has been extensively evaluated, and the possible risks are well understood.

Notice: this does not impact the openssf scorecard badge report, which is uploaded before filtering false positives.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
@henrirosten henrirosten marked this pull request as ready for review October 29, 2025 13:44
@brianmcgillion brianmcgillion merged commit a7d4367 into main Oct 29, 2025
27 of 28 checks passed
@brianmcgillion brianmcgillion deleted the disable-alerts-on-dangerous-trigger branch October 29, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants