Skip to content

lib: fix the propogation to ensure correct lib#1504

Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom
brianmcgillion:fix-library
Oct 26, 2025
Merged

lib: fix the propogation to ensure correct lib#1504
brianmcgillion merged 2 commits intotiiuae:mainfrom
brianmcgillion:fix-library

Conversation

@brianmcgillion
Copy link
Copy Markdown
Collaborator

There is a mix and match of which lib is being used in the system. Some cases using the standard lib and others using the extended lib. try to consolidate these to using the same extended lib.

Description of Changes

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. ...

There is a mix and match of which lib is being used in the system. Some
cases using the standard lib and others using the extended lib. try to
consolidate these to using the same extended lib.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Export the mk LaptopConfiguration and LaptopInstaller functions so that
downstream does not have to copy them in order to use them.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Copy link
Copy Markdown
Collaborator

@mbssrc mbssrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change. Perhaps we should move the permittedInsecurePackages at later stage?

@brianmcgillion brianmcgillion merged commit f14c4c9 into tiiuae:main Oct 26, 2025
28 checks passed
@brianmcgillion brianmcgillion deleted the fix-library branch October 26, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants