Skip to content

session-buddy: Update the hash to version 4.0.5#1484

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-chromeExtFix
Oct 21, 2025
Merged

session-buddy: Update the hash to version 4.0.5#1484
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-chromeExtFix

Conversation

@vunnyso
Copy link
Copy Markdown
Collaborator

@vunnyso vunnyso commented Oct 21, 2025

Description of Changes

Use the hardcoded version for installPhase.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Fixes https://jira.tii.ae/browse/SSRCSP-7435

@milva-unikie
Copy link
Copy Markdown

Tested on Lenovo-X1 (nixos-rebuild switch)

  • Session Buddy works

@milva-unikie milva-unikie added the Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon label Oct 21, 2025
@vunnyso vunnyso changed the title session-buddy: Update the hash to version of 4.0.5 session-buddy: Update the hash to version 4.0.5 Oct 21, 2025
Use the hardcoded version for installPhase.

Signed-off-by: Vunny Sodhi <vunny.sodhi@unikie.com>
@brianmcgillion brianmcgillion merged commit a1a8b5f into tiiuae:main Oct 21, 2025
28 checks passed
Comment on lines 26 to 35
Copy link
Copy Markdown
Collaborator

@henrirosten henrirosten Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we fetch the crx from https://clients2.google.com, based on the extension id and chrome version, but we don't specify the extension version (and it appears chrome extensions api doesn't even support fetching a given extension version).

When google updates the extension version at https://clients2.google.com, doesn't it cause a hash mismatch since the crx contents changes, causing a mismatch with the FOD hash? Worse, such change would go unnoticed, if the old package is cached.

What will drive the update of these extensions?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much idea about chrome extensions, I can check more on it.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kajusnau can share more insights, once he's back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants