Skip to content

Enable ghaf usb applet#1466

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
gngram:pr.usb_passthrough_applet
Oct 27, 2025
Merged

Enable ghaf usb applet#1466
brianmcgillion merged 1 commit intotiiuae:mainfrom
gngram:pr.usb_passthrough_applet

Conversation

@gngram
Copy link
Copy Markdown
Contributor

@gngram gngram commented Oct 15, 2025 •
edited
Loading

Description of Changes

  • Applet to manage usb passthrough

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • [x ] All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. attach any camera device
  2. click on the applet
  3. try to passthrough it in each allowed vm and check it is accessible

@gngram gngram requested a review from mbssrc October 15, 2025 19:26
@gngram gngram marked this pull request as draft October 15, 2025 19:32
@gngram gngram added the Needs Testing CI Team to pre-verify label Oct 15, 2025
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Oct 16, 2025

This should be reviewed in ghafpkgs before testing

@milva-unikie milva-unikie removed the Needs Testing CI Team to pre-verify label Oct 16, 2025
@gngram gngram force-pushed the pr.usb_passthrough_applet branch from bd383a3 to 17ab30c Compare October 17, 2025 11:57
@gngram gngram force-pushed the pr.usb_passthrough_applet branch from 17ab30c to 7b9bc3f Compare October 20, 2025 11:47
@gngram gngram force-pushed the pr.usb_passthrough_applet branch from 7b9bc3f to b76f94d Compare October 20, 2025 12:32
@gngram gngram force-pushed the pr.usb_passthrough_applet branch from b76f94d to fd4c8c1 Compare October 21, 2025 07:44
@gngram gngram force-pushed the pr.usb_passthrough_applet branch from fd4c8c1 to d0a8845 Compare October 21, 2025 14:38
kajusnau
kajusnau reviewed Oct 23, 2025
View reviewed changes
@gngram gngram force-pushed the pr.usb_passthrough_applet branch from d0a8845 to 78893dd Compare October 24, 2025 09:46
@gngram gngram force-pushed the pr.usb_passthrough_applet branch from 6ca91c6 to 1c2010d Compare October 24, 2025 15:36
@gngram gngram requested a review from kajusnau October 27, 2025 06:34
kajusnau
kajusnau reviewed Oct 27, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with some minor style suggestions.

@gngram gngram force-pushed the pr.usb_passthrough_applet branch from 1c2010d to ed0582d Compare October 27, 2025 08:03
@gngram
Copy link
Copy Markdown
Contributor Author

gngram commented Oct 27, 2025

rebased.

@gngram
Enable ghaf usb applet
a7cbeb2 
+ Applet to manage usb passthrough

Signed-off-by: Ganga Ram <Ganga.Ram@tii.ae>
@gngram gngram force-pushed the pr.usb_passthrough_applet branch from ed0582d to a7cbeb2 Compare October 27, 2025 08:09
@gngram gngram marked this pull request as ready for review October 27, 2025 09:04
@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Oct 27, 2025
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Oct 27, 2025

Tested on Lenovo X1 and Darter Pro (nixos-rebuild switch)
All good!

  • USB camera can be attached to business-vm or chrome-vm
  • User is prompted to select a VM when the camera is connected
  • Selected state persists between boots
  • No changes to integrated camera or other USB devices

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76 and removed Needs Testing CI Team to pre-verify labels Oct 27, 2025
@brianmcgillion brianmcgillion merged commit edd0ed7 into tiiuae:main Oct 27, 2025
28 checks passed
@gngram gngram deleted the pr.usb_passthrough_applet branch November 13, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@kajusnau kajusnau kajusnau approved these changes

@vunnyso vunnyso Awaiting requested review from vunnyso

@mbssrc mbssrc Awaiting requested review from mbssrc

Assignees

No one assigned

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gngram @milva-unikie @brianmcgillion @kajusnau