Skip to content

chrome: revert dedicated profiles for apps and browser#1452

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:chrome-adjust
Oct 9, 2025
Merged

chrome: revert dedicated profiles for apps and browser#1452
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:chrome-adjust

Conversation

@kajusnau
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau commented Oct 7, 2025 •
edited
Loading

Description of Changes

  1. Disable use of --profile-directory flag for chrome:

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation - Clean install or wipe /home/appuser/.config/google-chrome in the respective VM
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Test chrome tab sharing functionality in Teams, Trusted Browser, Slack, or wherever else.

@kajusnau
chrome: revert dedicated profiles for apps and browser
7ef910d 
- disable use of '--profile-directory' flag for chrome apps and browser

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@kajusnau kajusnau self-assigned this Oct 7, 2025
vunnyso
vunnyso reviewed Oct 7, 2025
View reviewed changes
@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Oct 7, 2025
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Oct 9, 2025

Tested on Lenovo X1 (nixos-rebuild switch, removed the Chrome config manually)

  • Sharing a Trusted Browser tab in a Teams meeting works again

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Oct 9, 2025
@kajusnau
Copy link
Copy Markdown
Collaborator Author

kajusnau commented Oct 9, 2025

RFM @brianmcgillion

@kajusnau kajusnau mentioned this pull request Oct 9, 2025
Merged
19 tasks
@brianmcgillion brianmcgillion merged commit efa12b1 into tiiuae:main Oct 9, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@vunnyso vunnyso vunnyso approved these changes

Assignees

@kajusnau kajusnau

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kajusnau @milva-unikie @brianmcgillion @vunnyso