Skip to content

Audio: Drop the removePciDevice workaround#1443

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-AudioImp
Oct 1, 2025
Merged

Audio: Drop the removePciDevice workaround#1443
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-AudioImp

Conversation

@vunnyso
Copy link
Copy Markdown
Collaborator

@vunnyso vunnyso commented Sep 30, 2025 •
edited
Loading

Description of Changes

This commit removes the removePciDevice entry from various hardware configurations. Now microvms now able to shut down cleanly, the removePciDevice workaround is no longer necessary. This removal is cleanup effort to eliminate redundant configurations.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Please test Audio related test cases thoroughly.

kajusnau
kajusnau approved these changes Sep 30, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@vunnyso vunnyso added the Needs Testing CI Team to pre-verify label Sep 30, 2025
@brianmcgillion
Copy link
Copy Markdown
Collaborator

brianmcgillion commented Sep 30, 2025

image

My kind of patch :)

@vunnyso
Copy link
Copy Markdown
Collaborator Author

vunnyso commented Oct 1, 2025

image

My kind of patch :)

Credits goes to @kajusnau for #1434 and @nesteroff for the suggestions 🙂

mbssrc
mbssrc reviewed Oct 1, 2025
View reviewed changes
@vunnyso
Audio: Drop the removePciDevice workaround
047754a 
This commit removes the removePciDevice entry
from various hardware configurations. Now microvms
now able to shut down cleanly, the removePciDevice
workaround is no longer necessary. This removal is
cleanup effort to eliminate redundant configurations.

Signed-off-by: Vunny Sodhi <vunny.sodhi@unikie.com>
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Oct 1, 2025

Tested on Lenovo-X1 and Darter Pro (nixos-rebuild switch)

  • No issues with audio

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76 and removed Needs Testing CI Team to pre-verify labels Oct 1, 2025
@brianmcgillion brianmcgillion merged commit e7b2150 into tiiuae:main Oct 1, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@mbssrc mbssrc mbssrc approved these changes

@kajusnau kajusnau kajusnau approved these changes

+1 more reviewer

@nesteroff nesteroff nesteroff left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vunnyso @brianmcgillion @milva-unikie @nesteroff @mbssrc @kajusnau