Skip to content

Update vhotplug to support new config format and external API#1389

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
nesteroff:vhotplug-update
Sep 17, 2025
Merged

Update vhotplug to support new config format and external API#1389
brianmcgillion merged 1 commit intotiiuae:mainfrom
nesteroff:vhotplug-update

Conversation

@nesteroff
Copy link
Copy Markdown
Contributor

@nesteroff nesteroff commented Sep 9, 2025 •
edited
Loading

Description of Changes

This updates vhotplug to the version with the new config format, which allows selecting multiple VMs for a single device.
It also adds support for the external API over VSOCK, which is required for the frontend GUI app.
No new functionality is added in this PR, but it is a prerequisite for the PR with the USB management app from Ganga.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

Overall USB hotplug testing is required to make sure this doesn’t introduce any regressions.

@nesteroff nesteroff marked this pull request as ready for review September 12, 2025 18:03
@nesteroff nesteroff added the Needs Testing CI Team to pre-verify label Sep 12, 2025
vunnyso
vunnyso reviewed Sep 15, 2025
View reviewed changes
vunnyso
vunnyso reviewed Sep 15, 2025
View reviewed changes
@gngram gngram mentioned this pull request Sep 15, 2025
Closed
19 tasks
@brianmcgillion
Copy link
Copy Markdown
Collaborator

brianmcgillion commented Sep 15, 2025 •
edited
Loading

@nesteroff I think you will have to rebase and fix the flake.nix . because https://github.com/tiiuae/ghaf/pull/1405/files#diff-206b9ce276ab5971a2489d75eb1b12999d4bf3843b7988cbe8d687cfde61dea0R85 pinned it to an older release of ghafpkgs

@nesteroff
Copy link
Copy Markdown
Contributor Author

nesteroff commented Sep 15, 2025

@nesteroff I think you will have to rebase and fix the flake.nix . because https://github.com/tiiuae/ghaf/pull/1405/files#diff-206b9ce276ab5971a2489d75eb1b12999d4bf3843b7988cbe8d687cfde61dea0R85 pinned it to an older release of ghafpkgs

Good point. I think it worked fine because of "rev": "f465691dd491e3a21f5a6e32e435ce3fb0d95525" in the lock file but now it should be cleaner.

@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Sep 16, 2025

Multiple devices are failing the boot test in pre-merge pipeline. The SSH connection goes to ghaf-host instead of net-vm on the laptops and on Orin-AGX. Orin-NX is connecting correctly. For all these targets we use an USB-Ethernet adapter.

@milva-unikie milva-unikie added bug Something isn't working and removed Needs Testing CI Team to pre-verify labels Sep 16, 2025
@nesteroff
Copy link
Copy Markdown
Contributor Author

nesteroff commented Sep 16, 2025

Multiple devices are failing the boot test in pre-merge pipeline. The SSH connection goes to ghaf-host instead of net-vm on the laptops and on Orin-AGX. Orin-NX is connecting correctly. For all these targets we use an USB-Ethernet adapter.

Thanks, Milla. Looks like it was the classic field renamed, bug gained. Should be fixed now.

@nesteroff
Update vhotplug to support new config format and external API
aac54fe 
Signed-off-by: Yuri Nesterov <yuriy.nesterov@unikie.com>
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Sep 17, 2025

Tested on Lenovo-X1 and Darter Pro (nixos-rebuild switch)

  • Did not notice any regression in USB devices

Thanks, Milla. Looks like it was the classic field renamed, bug gained. Should be fixed now.

Thank you, all tests passed in the latest run.

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76 and removed bug Something isn't working labels Sep 17, 2025
@brianmcgillion brianmcgillion merged commit 75ff83d into tiiuae:main Sep 17, 2025
28 checks passed
@vunnyso vunnyso mentioned this pull request Oct 13, 2025
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vunnyso vunnyso vunnyso approved these changes

Assignees

No one assigned

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nesteroff @brianmcgillion @milva-unikie @vunnyso