fix: Element issues by enesoztrk · Pull Request #1379 · tiiuae/ghaf

enesoztrk · 2025-09-04T16:10:58Z

Description of Changes

Element-web patch (Location sharing) has been disabled for now due to the version conflict with the current element-desktop
Latest element-desktop version tries to open an external URL to sign in/create accounts. That's why xdg handlers have been implemented.

Current issues

~~Chrome needs to redirect xdg-open requests with "element://vector..." url to comms-vm. But givc does not accept the URLs that do not start with "https,http,.."~~ https://github.com/tiiuae/ghaf-givc/blob/7a22955564248da50a213a7e386c2ef1e6f06c67/modules/pkgs/applications/applications.go#L67 @mbssrc
Element location sharing will not work (It is going to be fixed in the next PR)

Type of Change

New Feature
Bug Fix
Improvement / Refactor

Related Issues / Tickets

Checklist

Clear summary in PR description
Detailed and meaningful commit message(s)
Commits are logically organized and squashed if appropriate
Contribution guidelines followed
Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
Author has run make-checks and it passes
All automatic GitHub Action checks pass - see actions
Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

Installation Method

Requires full re-installation
Can be updated with nixos-rebuild ... switch
Other:

Test Steps To Verify:

Launch the element-desktop
Sign in/Create an account, and it will open the URL in chrome
Sign in/Create an account in chrome, and it will redirect to element-desktop app

Note: element-desktop location sharing functionality does not work for this PR.

modules/microvm/common/xdghandlers.nix

Copilot

Pull Request Overview

This PR addresses Element desktop application issues by implementing proper XDG handlers for URL redirection and temporarily disabling the element-web patch due to version conflicts.

Key changes:

Element-web package temporarily disabled due to version conflicts with element-desktop
Added comprehensive XDG handlers for URL and Element desktop protocol handling
Improved element-desktop integration with proper URL redirection support

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/own-pkgs-overlay.nix	Commented out element-web package due to version conflicts
overlays/custom-packages/element-desktop/element-main.patch	Updated patch with new URL loading and XDG utilities integration
overlays/custom-packages/element-desktop/default.nix	Enhanced element-desktop with XDG utilities and GPU/logging configuration
overlays/custom-packages/default.nix	Re-enabled element-desktop overlay
modules/reference/appvms/zathura.nix	Refactored XDG handlers from boolean to specific handler types
modules/reference/appvms/google-chrome.nix	Removed redundant Wayland flags for consistency
modules/reference/appvms/comms.nix	Added element-desktop XDG handler and logging flags
modules/microvm/common/xdgitems.nix	Major refactor to support URL and Element desktop XDG handling
modules/microvm/common/xdghandlers.nix	Converted from single enable flag to individual handler types

Comments suppressed due to low confidence (1)

modules/microvm/common/xdgitems.nix:1

Variable name confusion: filePath is being assigned the result of realpath on itself. This should be filePath=$(realpath "$file" || true) to get the real path of the original file parameter.

# Copyright 2022-2025 TII (SSRC) and the Ghaf contributors

overlays/custom-packages/element-desktop/default.nix

* disabling element-web patch due to conflict with latest version * xdg handler for external urls * xdg handler for element-desktop Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>

leivos-unikie · 2025-09-11T11:45:55Z

Also Orins are in the list of applicable targets. Does this mean that Element should launch also on Orins?

I checked on Orin NX that clicking the Element icon does nothing. I don't see any element related logs in journalctl or related process starting.

leivos-unikie · 2025-09-12T10:25:26Z

Tested on Lenovo-X1

Launching Element app works (just have to press "Use weaker encryption" at the pop-up)
Singing in to matrix server works, it opens chrome window (running in chrome-vm) for typing account credentials, then need to press "Open Ghaf Element Desktop" at pop-up on chrome to open the Element account on element app window (running in comms-vm).
Login state of Element app survives reboot
Also login state to matrix account in chrome-vm survives reboot
No regression found in basic GUI operation

NOTE:

Is it ok to launch the sign-in page on chrome in chrome-vm (less secure vm)? Could the sign-in page be launched in another chrome instance within comms-vm?

enesoztrk temporarily deployed to internal September 4, 2025 16:11 — with GitHub Actions Inactive

enesoztrk force-pushed the fix/element branch from 841f668 to 634f94d Compare September 4, 2025 16:36

enesoztrk temporarily deployed to internal September 4, 2025 16:36 — with GitHub Actions Inactive

enesoztrk temporarily deployed to internal September 4, 2025 16:37 — with GitHub Actions Inactive

enesoztrk temporarily deployed to internal September 5, 2025 09:49 — with GitHub Actions Inactive

enesoztrk temporarily deployed to internal September 5, 2025 09:50 — with GitHub Actions Inactive

enesoztrk requested review from brianmcgillion and mbssrc September 5, 2025 09:59

enesoztrk marked this pull request as ready for review September 8, 2025 06:05

enesoztrk force-pushed the fix/element branch from 02cb655 to fd24811 Compare September 10, 2025 06:29

enesoztrk temporarily deployed to internal September 10, 2025 06:29 — with GitHub Actions Inactive

enesoztrk force-pushed the fix/element branch from fd24811 to 03c1286 Compare September 10, 2025 08:20

enesoztrk temporarily deployed to internal September 10, 2025 08:20 — with GitHub Actions Inactive

enesoztrk force-pushed the fix/element branch from 03c1286 to a6f466e Compare September 10, 2025 08:25

enesoztrk temporarily deployed to internal September 10, 2025 08:25 — with GitHub Actions Inactive

enesoztrk temporarily deployed to internal September 10, 2025 08:26 — with GitHub Actions Inactive

brianmcgillion reviewed Sep 10, 2025

View reviewed changes

modules/microvm/common/xdghandlers.nix Outdated Show resolved Hide resolved

modules/microvm/common/xdghandlers.nix Outdated Show resolved Hide resolved

brianmcgillion requested a review from Copilot September 10, 2025 09:03

Copilot AI reviewed Sep 10, 2025

View reviewed changes

overlays/custom-packages/element-desktop/default.nix Outdated Show resolved Hide resolved

enesoztrk force-pushed the fix/element branch from a6f466e to 771ae4c Compare September 10, 2025 13:25

enesoztrk temporarily deployed to internal September 10, 2025 13:26 — with GitHub Actions Inactive

enesoztrk force-pushed the fix/element branch from 771ae4c to 1b04b3d Compare September 10, 2025 13:41

enesoztrk temporarily deployed to internal September 10, 2025 13:41 — with GitHub Actions Inactive

enesoztrk force-pushed the fix/element branch from 1b04b3d to 752f7cf Compare September 10, 2025 14:14

enesoztrk temporarily deployed to internal September 10, 2025 14:14 — with GitHub Actions Inactive

enesoztrk temporarily deployed to internal September 10, 2025 14:15 — with GitHub Actions Inactive

brianmcgillion approved these changes Sep 10, 2025

View reviewed changes

enesoztrk added the Needs Testing CI Team to pre-verify label Sep 10, 2025

fix: element-desktop issues

8b6371b

* disabling element-web patch due to conflict with latest version * xdg handler for external urls * xdg handler for element-desktop Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>

enesoztrk force-pushed the fix/element branch from 752f7cf to 8b6371b Compare September 11, 2025 05:54

enesoztrk temporarily deployed to internal September 11, 2025 05:54 — with GitHub Actions Inactive

enesoztrk temporarily deployed to internal September 11, 2025 05:55 — with GitHub Actions Inactive

leivos-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Sep 12, 2025

vunnyso approved these changes Sep 12, 2025

View reviewed changes

brianmcgillion merged commit 1dfbb27 into tiiuae:main Sep 12, 2025
28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Element issues#1379

fix: Element issues#1379
brianmcgillion merged 1 commit intotiiuae:mainfrom
enesoztrk:fix/element

enesoztrk commented Sep 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

leivos-unikie commented Sep 11, 2025

Uh oh!

leivos-unikie commented Sep 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

enesoztrk commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Changes

Type of Change

Related Issues / Tickets

Checklist

Testing Instructions

Applicable Targets

Installation Method

Test Steps To Verify:

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

leivos-unikie commented Sep 11, 2025

Uh oh!

leivos-unikie commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

enesoztrk commented Sep 4, 2025 •

edited

Loading

leivos-unikie commented Sep 12, 2025 •

edited

Loading