Skip to content

Protect admin VM from VM controls#1372

Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom
slakkala:dev/adminvm-protect
Sep 12, 2025
Merged

Protect admin VM from VM controls#1372
brianmcgillion merged 2 commits intotiiuae:mainfrom
slakkala:dev/adminvm-protect

Conversation

@slakkala
Copy link
Copy Markdown
Contributor

@slakkala slakkala commented Sep 4, 2025 •
edited
Loading

Description of Changes

Disable VM controls for admin-vm

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

https://jira.tii.ae/browse/SSRCSP-7025

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  • Launch Ghaf control panel
  • Choose admin VM (or any system VM)
  • VM controls dropdown button should be insensitive

@slakkala slakkala marked this pull request as draft September 4, 2025 07:56
@slakkala slakkala force-pushed the dev/adminvm-protect branch from c4f50d7 to ba5cd21 Compare September 8, 2025 07:39
@slakkala
Distinction of admin-vm and system-vms
a31a0c7 
Signed-off-by: Santtu Lakkala <santtu.lakkala@unikie.com>
@slakkala
Make adminHost singular
c357c89 
Signed-off-by: Santtu Lakkala <santtu.lakkala@unikie.com>
@slakkala slakkala requested a review from mbssrc September 11, 2025 08:27
@slakkala slakkala changed the title WIP: Protect admin VM from VM controls Protect admin VM from VM controls Sep 11, 2025
@slakkala slakkala marked this pull request as ready for review September 11, 2025 08:28
@slakkala slakkala added the Needs Testing CI Team to pre-verify label Sep 11, 2025
@leivos-unikie
Copy link
Copy Markdown
Contributor

leivos-unikie commented Sep 12, 2025 •
edited
Loading

Tested on Lenovo-X1

  • User can not shutdown or pause any of the system VMs via Control Panel (VM controls dropdown button is insensitive)

Other Notes on VM Controls (Is it ok to handle these in separate PR?):

  • Tested also Control Panel VM Controls of app VMs
  • Sometimes shutting down an appVM from its VM Controls caused VM Controls of other app VM to become disabled. (I could not reproduce this on following boots)
  • User is able to shutdown app VMs from Control Panel but there is no way to launch a VM via GUI once it has been shutdown.
  • User is able to stop givc service of an app VM but there is no way to restart the givc service via GUI once it has been stopped. Control Panel also shows "Running" as the state of the stopped givc service. Once givc service of an app VM is stopped the apps of that particular VM cannot be launched.

@leivos-unikie leivos-unikie added bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR labels Sep 12, 2025
@brianmcgillion brianmcgillion merged commit 090d642 into tiiuae:main Sep 12, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@mbssrc mbssrc Awaiting requested review from mbssrc

Assignees

No one assigned

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slakkala @leivos-unikie @brianmcgillion