Fix sign off in automated workflow for DCO compliance#1362
Merged
brianmcgillion merged 2 commits intomainfrom Sep 4, 2025
Merged
Fix sign off in automated workflow for DCO compliance#1362brianmcgillion merged 2 commits intomainfrom
brianmcgillion merged 2 commits intomainfrom
Conversation
Co-authored-by: brianmcgillion <1044263+brianmcgillion@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] fix sign off in automated workflow
Fix sign off in automated workflow for DCO compliance
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automated workflow
.github/workflows/update-npm-deps-hash.ymlwas not signing off commits, causing DCO (Developer Certificate of Origin) checks to fail. According to the project's contributing guidelines, all commits must include a "Signed-off-by:" trailer.The issue was in the commit step where
git commit -mwas used instead ofgit commit -s -m. The-sflag automatically adds the required sign-off line based on the configured git user name and email.Before:
git commit -m "Update npmDepsHash after npm dependency changes"After:
git commit -s -m "Update npmDepsHash after npm dependency changes"This ensures that automated commits from the workflow will include:
This minimal change maintains the existing functionality while ensuring DCO compliance for the automated npmDepsHash updates triggered by dependabot.
Fixes #1361.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.