enable graphical boot, bump ghafpkgs, adjust cosmic config#1339
Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom Sep 2, 2025
Merged
enable graphical boot, bump ghafpkgs, adjust cosmic config#1339brianmcgillion merged 1 commit intotiiuae:mainfrom
brianmcgillion merged 1 commit intotiiuae:mainfrom
Conversation
892ae3c to
56b0355
Compare
56b0355 to
b137597
Compare
b137597 to
e90136f
Compare
e90136f to
6985c5b
Compare
6985c5b to
5a687b7
Compare
5a687b7 to
bcdd3ed
Compare
bcdd3ed to
f95db56
Compare
brianmcgillion
approved these changes
Sep 1, 2025
f95db56 to
7469f89
Compare
mbssrc
approved these changes
Sep 2, 2025
vunnyso
approved these changes
Sep 2, 2025
Collaborator
vunnyso
left a comment
There was a problem hiding this comment.
Overall good, just minor comments. 🙂
|
Tested on Lenovo-X1 (
Notes
|
- bump ghafpkgs - enabled graphical boot with ghaf logo - expanded existing ghaf graphics boot module - minor simplification of cosmic config via cosmic osd Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
7469f89 to
0cf94f4
Compare
Collaborator
Author
|
Minor adjustments based on @vunnyso comments, no changes to functionality Ready to merge |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables graphical boot with a Ghaf-branded splash screen and simplifies cosmic desktop configuration. The changes implement plymouth-based graphical boot with customizable logos and remove redundant volume change sound handling in favor of cosmic's native implementation.
Key changes:
- Enable graphical boot with plymouth and Ghaf branding across different device profiles
- Add cosmic-osd package overlay to fix audio playback compatibility
- Simplify cosmic volume control configuration by leveraging built-in OSD functionality
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| overlays/custom-packages/default.nix | Adds cosmic-osd package to overlay |
| overlays/custom-packages/cosmic/cosmic-osd/default.nix | Creates cosmic-osd override to use paplay instead of pw-play |
| modules/reference/profiles/mvp-user-trial.nix | Removes commented boot graphics options and updates copyright |
| modules/reference/profiles/mvp-orinuser-trial.nix | Explicitly disables graphical boot for Orin devices |
| modules/reference/profiles/mvp-orinuser-trial-extras.nix | Explicitly disables graphical boot for Orin devices |
| modules/microvm/host/microvm-host.nix | Enables graphical boot on microvm host |
| modules/desktop/graphics/cosmic/config/cosmic-config.nix | Simplifies volume control shortcuts by removing custom sound playback |
| modules/desktop/graphics/boot.nix | Significantly expands boot graphics module with new configuration options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This change removes our own workaround for that in favor of using Cosmic's own implementation
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: