Skip to content

Lock user account after repeated failed login attempts#1324

Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom
gngram:zoo.faillock
Aug 21, 2025
Merged

Lock user account after repeated failed login attempts#1324
brianmcgillion merged 2 commits intotiiuae:mainfrom
gngram:zoo.faillock

Conversation

@gngram
Copy link
Copy Markdown
Contributor

@gngram gngram commented Aug 15, 2025

Description of Changes

Lock user account after repeated failed login attempts
Added option in login-manager to enable or disable this feature.
By default it is disabled, this feature is specifically enabled for Cosmic.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Try to login using wrong password, after 10 attempts your account is expected to be locked.

  2. You can reset it using privileged account using below command in gui-vm:

$> sudo faillock --user <username> --reset

@milva-unikie
Copy link
Copy Markdown

Tested on Lenovo-X1 (nixos-rebuild switch)

  • User account got locked after 10 failed login attempts
  • Resetting the account works
  • Test-automation passes

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Aug 18, 2025
@vunnyso
Copy link
Copy Markdown
Collaborator

vunnyso commented Aug 21, 2025

Please rebase.

gngram added 2 commits August 21, 2025 10:36
Added option in login-manager to enable or disable this feature.
By default it is disabled.

Signed-off-by: Ganga Ram <Ganga.Ram@tii.ae>
Signed-off-by: Ganga Ram <Ganga.Ram@tii.ae>
@brianmcgillion brianmcgillion merged commit 89e4fe2 into tiiuae:main Aug 21, 2025
28 checks passed
@gngram gngram deleted the zoo.faillock branch October 27, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants