Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

feat: $push field operator for update#363

Merged
ovaistariq merged 2 commits intotigrisdata-archive:mainfrom
akhill10:feat/push-field-for-update
May 12, 2023
Merged

feat: $push field operator for update#363
ovaistariq merged 2 commits intotigrisdata-archive:mainfrom
akhill10:feat/push-field-for-update

Conversation

@akhill10
Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

tigrisdata-archive/tigrisdb#893 (comment)

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Is this change backwards compatible?

  • Yes
  • No, and this is why: please replace this line with details on why?

Does it require updates to Tigris docs?

  • Yes, and here is the link: please create an issue in tigris-docs repo
    and replace this text as tigrisdata/tigris-docs#123
  • No

Checklist

  • npm run build - builds successfully
  • npm run test - tests passing
  • npm run lint - no lint errors

[optional] Are there any post deployment tasks we need to perform?

@reviewpad reviewpad Bot added the small Pull request is small label May 10, 2023
@Field()
publisher: Publisher;

@Field(TigrisDataTypes.ARRAY, { elements: TigrisDataTypes.OBJECT })
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elements: Author

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak in the test and then we should be able to merge

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (9d845b4) 90.24% compared to head (629297e) 90.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   90.24%   90.27%   +0.03%     
==========================================
  Files          29       29              
  Lines        5595     5613      +18     
  Branches      657      662       +5     
==========================================
+ Hits         5049     5067      +18     
  Misses        545      545              
  Partials        1        1              
Impacted Files Coverage Δ
src/types.ts 91.37% <100.00%> (+0.01%) ⬆️
src/utility.ts 92.83% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovaistariq ovaistariq merged commit fb46723 into tigrisdata-archive:main May 12, 2023
@ovaistariq
Copy link
Copy Markdown
Contributor

/tip $10

@algora-pbc
Copy link
Copy Markdown

algora-pbc Bot commented May 12, 2023

🎉🎈 @akhill10 has been awarded $10.00! 🎈🎊

@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants