Allow TCP DNS queries to kube-dns in the default deny policy#1096
Merged
ctauchen merged 1 commit intotigera:mainfrom Nov 21, 2023
Merged
Allow TCP DNS queries to kube-dns in the default deny policy#1096ctauchen merged 1 commit intotigera:mainfrom
ctauchen merged 1 commit intotigera:mainfrom
Conversation
In cert-manager/website#1344 (comment) we're discussing whether the default Calico deny policy should also allow TCP DNS queries. Is there a reason to block them?
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
Collaborator
|
Thanks for the submission, @wallrj. This subject of this is out of scope for a docs-only discussion. The question isn't "How should we be documenting X?" so much as "How should we do/write/build X?" I suggest you raise an issue with Project Calico and add link to this PR. |
Contributor
Author
Done: |
matthewdupre
approved these changes
Nov 20, 2023
Member
matthewdupre
left a comment
There was a problem hiding this comment.
This is a better policy than the existing one.
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cert-manager/website#1344 (comment) we're discussing whether the default Calico deny policy should also allow TCP DNS queries.
Is there a reason to block them?
Fixes: projectcalico/calico#8224
Product Version(s):
Issue:
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: